[GitHub] [kafka] chia7712 commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #11296:
URL: https://github.com/apache/kafka/pull/11296#discussion_r702636878



##########
File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java
##########
@@ -45,7 +44,7 @@
     private final MockTime time = new MockTime();
     private final int electionTimeoutMs = 5000;
     private final int fetchTimeoutMs = 10000;
-    private final Random random = Mockito.spy(new Random(1));
+    private final MockableRandom random = new MockableRandom(1L);

Review comment:
       pardon me. Is this a kind of refactor? or `spy` can't work after updating to jdk 17?

##########
File path: raft/src/test/java/org/apache/kafka/raft/MockableRandom.java
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.raft;
+
+import java.util.OptionalInt;
+import java.util.Random;
+import java.util.function.IntFunction;
+
+/**
+ * A Random instance that makes it easy to modify the behavior of certain methods for test purposes.
+ */
+class MockableRandom extends Random {
+
+    private IntFunction<OptionalInt> nextIntFunction = __ -> OptionalInt.empty();
+
+    public MockableRandom(long seed) {
+        super(seed);
+    }
+
+    /**
+     * If the function returns an empty option, `nextInt` behaves as usual. Otherwise, the integer
+     * returned from `function` is returned by `nextInt`.
+     */
+    private void mockNextInt(IntFunction<OptionalInt> function) {

Review comment:
       this method is unused but it maybe useful in the future.

##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##########
@@ -164,7 +162,7 @@ Builder withVotedCandidate(int epoch, int votedId) throws IOException {
             return this;
         }
 
-        Builder updateRandom(Consumer<Random> consumer) {
+        Builder updateRandom(Consumer<MockableRandom> consumer) {

Review comment:
       Is it more flexible if we keep using `Random` type?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org