[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5647: assume a property is one when it isn't a number

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5647:
URL: https://github.com/apache/cloudstack/pull/5647#discussion_r740123794



##########
File path: core/src/main/java/com/cloud/storage/template/OVAProcessor.java
##########
@@ -246,7 +246,17 @@ public long getTemplateVirtualSize(String templatePath, String templateName) thr
             NodeList diskElements = new OVFHelper().getElementsByTagNameAndPrefix(ovfDoc, "Disk", "ovf");
             for (int i = 0; i < diskElements.getLength(); i++) {
                 Element disk = (Element)diskElements.item(i);
-                long diskSize = Long.parseLong(disk.getAttribute("ovf:capacity"));
+                String diskSizeValue = disk.getAttribute("ovf:capacity");
+                long diskSize = 1;

Review comment:
       not sure here if we should 'some' or 0 (zero)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org