You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/01 23:05:45 UTC
[GitHub] [trafficserver] dragon512 opened a new pull request #7236: clean up body factory tests
dragon512 opened a new pull request #7236:
URL: https://github.com/apache/trafficserver/pull/7236
The goal here is to clean up some tests that have this awful ( subjective) piping that takes time. The gold files have been cleaned up as a few have a extra /n in them that don't report well currently in AuTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 commented on pull request #7236: clean up body factory tests
Posted by GitBox <gi...@apache.org>.
dragon512 commented on pull request #7236:
URL: https://github.com/apache/trafficserver/pull/7236#issuecomment-702448122
@masaori335 I hope this PR clean up help shows that a lot of what is going on is not needed. I do however need to have the gold file tester show \n better as that is a utter pain to understand this is the issue today with the autest report
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 merged pull request #7236: clean up body factory tests
Posted by GitBox <gi...@apache.org>.
dragon512 merged pull request #7236:
URL: https://github.com/apache/trafficserver/pull/7236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 commented on pull request #7236: clean up body factory tests
Posted by GitBox <gi...@apache.org>.
dragon512 commented on pull request #7236:
URL: https://github.com/apache/trafficserver/pull/7236#issuecomment-702751630
I agree. However the from the user point of view is it obvious in many of the ats cases why the file is different I have to address this better in AuTest. The main issue seems to be that ATS is sensitive to whitespace and the gold tester is not showing this well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] dragon512 commented on pull request #7236: clean up body factory tests
Posted by GitBox <gi...@apache.org>.
dragon512 commented on pull request #7236:
URL: https://github.com/apache/trafficserver/pull/7236#issuecomment-702442602
Just as a note for the reviewers... sys.executable allow us to use the same version of python we are using with autest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org