You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2017/06/26 17:32:49 UTC
[GitHub] cordova-android pull request #389: CB-11244: Studio Project Compatibility: N...
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/389
CB-11244: Studio Project Compatibility: Now with merge commit
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This PR is the new current working PR for the Studio Project work
### What testing has been done on this change?
Tested against the CI tests, more tests need to be added.
### Checklist
- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-android StudioProjectCompat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #389
----
commit d88df59c32ae7d1a55729477f5a22d9e7b4df111
Author: Joe Bowser <bo...@apache.org>
Date: 2017-03-30T19:41:44Z
Adding the Studio Builder to build a project based on Android Studio,
and deleting Ant, since Google does not support Ant Builds anymore.
Sorry guys!
commit 23d8d999257f9cf1331d81489c96f00fa134b3b5
Author: Joe Bowser <bo...@apache.org>
Date: 2017-03-30T20:38:18Z
Moving Android Manifest finding to the Gradle and Studio builders.
commit ffadf5dd51767c2f2697ad9e1ba34cf44d652145
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-03T22:21:48Z
Changing this so we pass lint
commit 7b17abc5553ca14f69081a2175f787d4a0550f0f
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-04T20:38:40Z
Fixing linting issues
commit f790aeb8f677eb047ce6e82fceaeb814cfc9d4fc
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-04T22:18:46Z
Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle
commit b73c04f3c8424e6db57c3bb98c550cd4d976f473
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-04T22:34:42Z
Updating gradle version in the build file
commit 8ead919faea814e86e8f665e9122a35bcd82d869
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-04T22:42:58Z
Managed to get the project to mostly compile, still need to re-work the build command to add the app project
commit db87e0ae6a25d8a337d10b41cb46574e2cb987b0
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-11T20:47:40Z
Made changes so cordova/build builds with the new project. Need to work on plugin installation.
commit a216f0db751778953224067f25b8e0077bb7e760
Author: Joe Bowser <bo...@apache.org>
Date: 2017-01-04T19:48:18Z
CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback
commit 69260fb96a8d606549caa8880abc5e7b444c4621
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-11T21:41:27Z
Fix the overwriting of Fil's fix, blargh
commit 69ab6a0e0d70e56c6fe0fe7529a211c51df09ab7
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-18T21:29:02Z
Changing the project to add the app directory as a dependency
commit 8391af2e8f6d9bdab102f28c58f257b8b53d0c0f
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-18T21:48:56Z
JsHint Fixes, deleting unused methods
commit 304a8991140f3f1ed76a9816b1a4d701537f89ea
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-19T18:50:55Z
Fixed the specification of the builders in the run command by getting build to check what was being passed from run
commit e621edfba755d31915da29a6113b0be2db56735f
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-21T23:27:26Z
Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova
commit bd4ddcdeddf7a5b232023c4f53b60d2ab20e7a48
Author: Joe Bowser <bo...@apache.org>
Date: 2017-04-22T00:02:27Z
Updated AndroidStudio to only look for the app directory to determine studio status
commit 28ebbb8f024f31a627af6b26ba23e41e7ce22f65
Author: Joe Bowser <bo...@apache.org>
Date: 2017-05-31T17:23:35Z
CB-11244: Setup Api.js to support multiple builders based on project structure
commit fb6cb51e64a2ea05ba65195023b702fb00b378c2
Author: Joe Bowser <bo...@apache.org>
Date: 2017-05-31T17:37:47Z
Fixing lint errors
commit 8f16df4c90bd4a9ea64f537d85db5ce6069b5c04
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-13T15:27:46Z
Adding logic to upgrade both Classic and Android Studio style project structures
commit 33feb00e8f383cd99ce59a052171d6d35c61094c
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-13T17:11:41Z
Adding the if statement to see if we can support both structures with minimal editing, TODO: actually write tests for this somehow
commit c74192d578e647a8386ac8663d6c99521f28b110
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-13T17:36:00Z
Adding conditional code into Gradle, this is a bit dirty since we can't explicitly test it but we'll just have to rely on jasmine
commit b67e9905bccde0b6188bd2c6f16dae34d09b9d35
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-13T18:58:00Z
This is probably a bad idea, but we need to split the gradle files into legacy and new style
commit 40c9709445ef77fa97cc8d2d65cc961860a3046e
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-14T16:34:15Z
OK, Going back to the old build.gradle for legacy projects
commit c0474e811dd6387beefe8b5b5b036ee773a87126
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-14T17:16:05Z
Bump for travis test
commit 49b76f5c7138684455af69b030bce71f290de31f
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-14T18:36:43Z
Fixing mangled commits that crept into this branch
commit 1cda7a9de000bc71f920412286646803fa539ef4
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-19T21:34:03Z
CB-11244: Found bug in Api.js where xml/strings.xml is used instead of values/strings.xml
commit b20028c42b0363ec27df304ba74a7d3d6003ad9f
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-22T20:46:18Z
The prepare step was broken, which breaks the CLI workflow. This was caused by hardcoding the Java directory, which is a very bad idea.
commit e456175a815e2812c1ce249d7460cbe8dfe340a2
Author: Joe Bowser <bo...@apache.org>
Date: 2017-06-26T17:29:31Z
Merge branch 'master' into StudioProjectCompat
This will have to be linted
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Hey @infil00p, latest master has a tiny tweak to the appveyor build file that works around some troubles appveyor is experiencing with one of their VM images. I think if you rebase this, you'll find that'll clear up the appveyor failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Right and that is now 3 commits behind master's `HEAD` :P
Just saying latest master stuff will get you better testing / feedback via CI in this PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Github says otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/389
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=h1) Report
> Merging [#389](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/893356abcd1b005a13bb09e7467f227b52de3ae5?src=pr&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `34.17%`.
[](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 42.55% 42.17% -0.38%
==========================================
Files 17 17
Lines 1678 1707 +29
Branches 304 310 +6
==========================================
+ Hits 714 720 +6
- Misses 964 987 +23
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/templates/cordova/lib/builders/GenericBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HZW5lcmljQnVpbGRlci5qcw==) | `30.61% <ø> (-0.38%)` | :arrow_down: |
| [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `37.5% <ø> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `13.04% <0%> (-0.39%)` | :arrow_down: |
| [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `22.44% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/AndroidStudio.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkU3R1ZGlvLmpz) | `94.73% <100%> (ø)` | :arrow_up: |
| [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20% <15.78%> (-0.43%)` | :arrow_down: |
| [bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==) | `43.36% <25%> (-1.09%)` | :arrow_down: |
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `49.26% <45.45%> (-1.57%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=footer). Last update [893356a...d0dab4b](https://codecov.io/gh/apache/cordova-android/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Just based on the last travis/appveyor run in the commits in this PR, the unit tests, end to end tests and the native unit tests are not running.
I don't see master HEAD in the commit list for this branch, either:
```
* a7304b9a - (HEAD -> StudioProjectCompat, infil00p/StudioProjectCompat) Finishing the linting (2 weeks ago) <Joe Bowser>
* e456175a - Merge branch 'master' into StudioProjectCompat (2 weeks ago) <Joe Bowser>
|\
| * 55d7cf38 - CB-12895 : updated .eslintrc file in spec dir and set jasmine true and removed root is true (3 weeks ago) <Audrey So>
| * ac4ac935 - CB-12895 : added .eslintrc files to set up jasmine environment (3 weeks ago) <Audrey So>
| * d83d49d8 - CB-12895 : fixed eslint errors (3 weeks ago) <Audrey So>
| * e36158a0 - CB-12895 : added eslint and removed jshint (3 weeks ago) <Audrey So>
| * 5cc14b80 - CB-12605 In Windows get Android studio path from the registry (3 weeks ago) <Jesse MacFadyen>
* | b20028c4 - (infil00p/StudioProjectCleanup, StudioProjectCleanup) The prepare step was broken, which breaks the CLI workflow. This was caused by hardcoding the Java directory, which is a very bad idea. (3 weeks ago) <Joe Bowser>
* | 1cda7a9d - CB-11244: Found bug in Api.js where xml/strings.xml is used instead of values/strings.xml (3 weeks ago) <Joe Bowser>
* | 49b76f5c - Fixing mangled commits that crept into this branch (4 weeks ago) <Joe Bowser>
* | c0474e81 - Bump for travis test (4 weeks ago) <Joe Bowser>
* | 40c97094 - OK, Going back to the old build.gradle for legacy projects (4 weeks ago) <Joe Bowser>
* | b67e9905 - This is probably a bad idea, but we need to split the gradle files into legacy and new style (4 weeks ago) <Joe Bowser>
* | c74192d5 - Adding conditional code into Gradle, this is a bit dirty since we can't explicitly test it but we'll just have to rely on jasmine (4 weeks ago) <Joe Bowser>
* | 33feb00e - Adding the if statement to see if we can support both structures with minimal editing, TODO: actually write tests for this somehow (4 weeks ago) <Joe Bowser>
* | 8f16df4c - Adding logic to upgrade both Classic and Android Studio style project structures (4 weeks ago) <Joe Bowser>
* | fb6cb51e - Fixing lint errors (4 weeks ago) <Joe Bowser>
* | 28ebbb8f - CB-11244: Setup Api.js to support multiple builders based on project structure (4 weeks ago) <Joe Bowser>
* | bd4ddcde - Updated AndroidStudio to only look for the app directory to determine studio status (4 weeks ago) <Joe Bowser>
* | e621edfb - Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova (4 weeks ago) <Joe Bowser>
* | 304a8991 - Fixed the specification of the builders in the run command by getting build to check what was being passed from run (4 weeks ago) <Joe Bowser>
* | 8391af2e - JsHint Fixes, deleting unused methods (4 weeks ago) <Joe Bowser>
* | 69ab6a0e - Changing the project to add the app directory as a dependency (4 weeks ago) <Joe Bowser>
* | a216f0db - CB-11244: Changing directory creation, will most likely hide this behind a flag for the next release of Cordova-Android, and then make it default in the next major pending feedback (4 weeks ago) <Joe Bowser>
* | 69260fb9 - Fix the overwriting of Fil's fix, blargh (4 weeks ago) <Joe Bowser>
* | db87e0ae - Made changes so cordova/build builds with the new project. Need to work on plugin installation. (4 weeks ago) <Joe Bowser>
* | 8ead919f - Managed to get the project to mostly compile, still need to re-work the build command to add the app project (4 weeks ago) <Joe Bowser>
* | b73c04f3 - Updating gradle version in the build file (4 weeks ago) <Joe Bowser>
* | f790aeb8 - Setting up the create command so we actually have all the directories in the right place, and define default variables in the top level build.gradle (4 weeks ago) <Joe Bowser>
* | 7b17abc5 - Fixing linting issues (4 weeks ago) <Joe Bowser>
* | ffadf5dd - Changing this so we pass lint (4 weeks ago) <Joe Bowser>
* | 23d8d999 - Moving Android Manifest finding to the Gradle and Studio builders. (4 weeks ago) <Joe Bowser>
* | d88df59c - Adding the Studio Builder to build a project based on Android Studio, and deleting Ant, since Google does not support Ant Builds anymore. Sorry guys! (4 weeks ago) <Joe Bowser>
|/
* 3a6e898b - CB-12762 : pointed package.json repo items to github mirrors instead of apache repos site (5 weeks ago) <Audrey So>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Given how old this branch is, those are the same tests that master was running until three commits ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Maybe? I don't know. Just beware that you have very few tests running in this PR (basically just the JS unit tests, no JS e2e nor Java native unit tests) so the green checkmark next to your PR is a bit of a false positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Heh, with me merging in #391, you might need to rebase 🙈
At least you'll get wider test feedback on Windows with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
The merge commit that I did was e456175a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj So, I should do another merge commit just to get more tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Yes, seriously, because the code interpolates activity name / package name / etc. into hard-coded paths!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Hard copied paths? SRSLY?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org