You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jkbkupczyk (via GitHub)" <gi...@apache.org> on 2023/06/24 13:06:26 UTC
[GitHub] [commons-csv] jkbkupczyk opened a new pull request, #328: Add missing docs
jkbkupczyk opened a new pull request, #328:
URL: https://github.com/apache/commons-csv/pull/328
- Adds missing JavaDoc documentation for the `CSVFormat` constructor and print methods
- Fixes some typos
FYI @garydgregory @kinow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] jkbkupczyk commented on pull request #328: Add missing docs
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #328:
URL: https://github.com/apache/commons-csv/pull/328#issuecomment-1605571577
> Please don't change code in a PR that says it is only about documentation. The code changes seem superfluous.
@garydgregory
Rollbacked the code changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #328: Add missing docs
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #328:
URL: https://github.com/apache/commons-csv/pull/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #328: Add missing docs
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #328:
URL: https://github.com/apache/commons-csv/pull/328#issuecomment-1605704695
> > Please don't change code in a PR that says it is only about documentation. The code changes seem superfluous.
>
> @garydgregory Rollbacked the code changes
TY @jkbkupczyk !👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] codecov-commenter commented on pull request #328: Add missing docs
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #328:
URL: https://github.com/apache/commons-csv/pull/328#issuecomment-1605529087
## [Codecov](https://app.codecov.io/gh/apache/commons-csv/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#328](https://app.codecov.io/gh/apache/commons-csv/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1da5a8b) into [master](https://app.codecov.io/gh/apache/commons-csv/commit/8f07f102a37356922e7493723769dd49f93f3511?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8f07f10) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #328 +/- ##
=========================================
Coverage 97.87% 97.87%
Complexity 549 549
=========================================
Files 11 11
Lines 1178 1179 +1
Branches 204 205 +1
=========================================
+ Hits 1153 1154 +1
Misses 13 13
Partials 12 12
```
| [Impacted Files](https://app.codecov.io/gh/apache/commons-csv/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rc/main/java/org/apache/commons/csv/CSVFormat.java](https://app.codecov.io/gh/apache/commons-csv/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVkZvcm1hdC5qYXZh) | `98.02% <ø> (ø)` | |
| [...rc/main/java/org/apache/commons/csv/CSVRecord.java](https://app.codecov.io/gh/apache/commons-csv/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVlJlY29yZC5qYXZh) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org