You are viewing a plain text version of this content. The canonical link for it is here.
Posted to infrastructure-issues@apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/06/11 17:10:14 UTC
[jira] Created: (INFRA-2788) shorten.pl has incorrect $dbfile
definition
shorten.pl has incorrect $dbfile definition
-------------------------------------------
Key: INFRA-2788
URL: https://issues.apache.org/jira/browse/INFRA-2788
Project: Infrastructure
Issue Type: Bug
Security Level: public (Regular issues)
Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/shorten/shorten.pl
Reporter: Sebb
Priority: Minor
I think the line
$dbfile = '../db/store.dbm';
should really be
$dbfile = 'store.dbm';
because the file is relative to the -Home flag, not the current working directory.
The ../db obviously works, but serves no purpose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (INFRA-2788) shorten.pl has incorrect $dbfile
definition
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
#asfinfra IRC Bot closed INFRA-2788.
------------------------------------
Resolution: Fixed
> shorten.pl has incorrect $dbfile definition
> -------------------------------------------
>
> Key: INFRA-2788
> URL: https://issues.apache.org/jira/browse/INFRA-2788
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/shorten/shorten.pl
> Reporter: Sebb
> Priority: Minor
>
> I think the line
> $dbfile = '../db/store.dbm';
> should really be
> $dbfile = 'store.dbm';
> because the file is relative to the -Home flag, not the current working directory.
> The ../db obviously works, but serves no purpose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-2788) shorten.pl has incorrect $dbfile
definition
Posted by "Tony Stevenson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927452#action_12927452 ]
Tony Stevenson commented on INFRA-2788:
---------------------------------------
Sebb,
Do you have a patch? If so, send it over and I'll see about patching it
> shorten.pl has incorrect $dbfile definition
> -------------------------------------------
>
> Key: INFRA-2788
> URL: https://issues.apache.org/jira/browse/INFRA-2788
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/shorten/shorten.pl
> Reporter: Sebb
> Priority: Minor
>
> I think the line
> $dbfile = '../db/store.dbm';
> should really be
> $dbfile = 'store.dbm';
> because the file is relative to the -Home flag, not the current working directory.
> The ../db obviously works, but serves no purpose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (INFRA-2788) shorten.pl has incorrect $dbfile
definition
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb reopened INFRA-2788:
-------------------------
OK.
Another problem is the use of the DB_CREATE flag.
Should the database ever disappear, a new one will silently be created.
Which would allow duplicate keys to be created. Not good.
Seems to me it would be a lot safer to require that the database exists and fail otherwise.
> shorten.pl has incorrect $dbfile definition
> -------------------------------------------
>
> Key: INFRA-2788
> URL: https://issues.apache.org/jira/browse/INFRA-2788
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/shorten/shorten.pl
> Reporter: Sebb
> Priority: Minor
>
> I think the line
> $dbfile = '../db/store.dbm';
> should really be
> $dbfile = 'store.dbm';
> because the file is relative to the -Home flag, not the current working directory.
> The ../db obviously works, but serves no purpose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (INFRA-2788) shorten.pl has incorrect $dbfile
definition
Posted by "#asfinfra IRC Bot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877828#action_12877828 ]
#asfinfra IRC Bot commented on INFRA-2788:
------------------------------------------
<joes4> i'd rather not change the script unless it's fundamentally broken. right now it does the right thing, so let's leave well enough alone. but thanks for pointing it out.
> shorten.pl has incorrect $dbfile definition
> -------------------------------------------
>
> Key: INFRA-2788
> URL: https://issues.apache.org/jira/browse/INFRA-2788
> Project: Infrastructure
> Issue Type: Bug
> Security Level: public(Regular issues)
> Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/shorten/shorten.pl
> Reporter: Sebb
> Priority: Minor
>
> I think the line
> $dbfile = '../db/store.dbm';
> should really be
> $dbfile = 'store.dbm';
> because the file is relative to the -Home flag, not the current working directory.
> The ../db obviously works, but serves no purpose.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.