[GitHub] [hudi] vinothchandar commented on a change in pull request #2925: [HUDI-1879] Fix RO Tables Returning Snapshot Result

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #2925:
URL: https://github.com/apache/hudi/pull/2925#discussion_r629953740



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DefaultHoodieConfig.java
##########
@@ -26,6 +26,11 @@
  */
 public class DefaultHoodieConfig implements Serializable {
 
+  public static final String QUERY_TYPE_OPT_KEY = "hoodie.datasource.query.type";

Review comment:
       common module should be completely unaware of query types etc.. What the intention for moving this here

##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -50,10 +51,10 @@ object DataSourceReadOptions {
     *
     * Default: snapshot
     */
-  val QUERY_TYPE_OPT_KEY = "hoodie.datasource.query.type"
-  val QUERY_TYPE_SNAPSHOT_OPT_VAL = "snapshot"
-  val QUERY_TYPE_READ_OPTIMIZED_OPT_VAL = "read_optimized"
-  val QUERY_TYPE_INCREMENTAL_OPT_VAL = "incremental"
+  val QUERY_TYPE_OPT_KEY = DefaultHoodieConfig.QUERY_TYPE_OPT_KEY

Review comment:
       lets not have these params in `DefaultHoodieConfig` >




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org