You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/07/01 17:43:47 UTC
[jira] Created: (HBASE-1599) Fix TestFilterSet, broken up on hudson
Fix TestFilterSet, broken up on hudson
--------------------------------------
Key: HBASE-1599
URL: https://issues.apache.org/jira/browse/HBASE-1599
Project: Hadoop HBase
Issue Type: Bug
Reporter: stack
Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1599) Fix TestFilterSet, broken up on
hudson
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray reassigned HBASE-1599:
------------------------------------
Assignee: Jonathan Gray
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1599) Fix TestFilterSet, broken up on hudson
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1599:
---------------------------------
Status: Patch Available (was: Open)
Ready for review.
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1599-v1.patch
>
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1599) Fix TestFilterSet, broken up on
hudson
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726305#action_12726305 ]
stack commented on HBASE-1599:
------------------------------
Chatting with JGray, a filter backed by a Set is not a good idea. Should be a sorted Set at least or a List so behavior is determinate.
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1599) Fix TestFilterSet, broken up on hudson
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1599:
-------------------------
Fix Version/s: 0.20.0
Bringing into 0.20.0. I think this kinda critical.
@Clint, I'm thinking that rather than FilterSet, that instead we have FilterList. You add the filters in the order in which you want them to run rather than have them run in an order that might vary from JVM to JVM. What you think?
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.0
>
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1599) Fix TestFilterSet, broken up on hudson
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1599:
---------------------------------
Attachment: HBASE-1599-v2.patch
Working patch.
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1599-v1.patch, HBASE-1599-v2.patch
>
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1599) Fix TestFilterSet, broken up on hudson
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1599:
---------------------------------
Attachment: HBASE-1599-v1.patch
Changes FilterSet to FilterList. Changes subsequent tests.
Changes PageFilter to consider a page to be a row (was a KV). Should create separate filters to do KV limits (or some filter that could limit cols/family, etc)
Fixes the test that was broken on hudson to consider the ordering of the filters in the FilterList.
Adds a new test, testOrdering() to test the FilterList ordering.
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1599-v1.patch
>
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1599) Fix TestFilterSet, broken up on hudson
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1599:
-------------------------
Resolution: Fixed
Release Note: Recast FilterSet as a FilterList
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Thanks for the fix Jon.
> Fix TestFilterSet, broken up on hudson
> --------------------------------------
>
> Key: HBASE-1599
> URL: https://issues.apache.org/jira/browse/HBASE-1599
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: HBASE-1599-v1.patch, HBASE-1599-v2.patch
>
>
> Hmm.. TestFilterSet works in IDE but not up on hudson.... look into this. For now commenting out piece thats failing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.