You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2026/09/02 09:13:10 UTC

[PR] Add BanyanDB trace tail sampling monitoring [skywalking]

wankai123 opened a new pull request, #14052:
URL: https://github.com/apache/skywalking/pull/14052

   Add otel-rules/banyandb/banyandb-trace-sampling.yaml, 41 rules covering the banyandb_trace_pipeline_* / banyandb_trace_tst_pipeline_* catalog a sampler plugin chain emits. Modeled at Service scope with `group` kept as a metric label rather than at Endpoint scope, so one cluster-wide page can render per-group series and cluster totals alike.
   
   Add the e2e case test/e2e-v2/cases/banyandb/trace-sampling, registered in the e2e-test matrix. It runs a real sw-trace-sampler chain on the plugin-capable BanyanDB image and asserts the 17 rules a healthy, fully-dropping run can produce; the other 24 cover failure counters, the keep verdict, FINALIZE-only state and back-pressure guards that cannot occur in a short healthy run. The existing BanyanDB self-observability case cannot cover any of this: its cluster runs no sampler plugins, so the wire families never register.
   
   Fix a cross-rule CounterWindow key collision in the v2 MAL engine. rate() / increase() / irate() resolved their lower bound from a process-wide window keyed on the counter name plus its post-.sum(...) label set, with nothing identifying the evaluating rule, so two rules reading one wire family and dropping the label they filtered on collapsed onto one slot and differenced against each other's values. The window is now keyed by owning rule as well. Auditing the shipped rules gives 10 colliding keys over ~25 rules.
   
   Fix meter_rabbitmq_node_outgoing_messages_total double-counting rabbitmq_global_messages_delivered_get_auto_ack_total, which appeared twice among the six summed delivery terms.
   
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [X] Update the documentation to include this new feature.
   - [X] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add BanyanDB trace tail sampling monitoring [skywalking]

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 merged PR #14052:
URL: https://github.com/apache/skywalking/pull/14052


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org