You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/23 07:52:56 UTC

[GitHub] [airflow] nurikk opened a new pull request #5317: Fix missing try_number parameter in TaskInstance.log_filepath method

nurikk opened a new pull request #5317: Fix missing try_number parameter in TaskInstance.log_filepath method
URL: https://github.com/apache/airflow/pull/5317
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [AIRFLOW-4562](https://issues.apache.org/jira/browse/AIRFLOW-4562) issues and references them in the PR title.
   ### Description
   
       This PR fixes wrong log file name generation for TaskInstance.
       Old implementation didn't support try_number property.
       And generated wrong file name.
       (this methdod is used in task failure notiofication message generation)
   
       More over this commit improves log_url generation add adds try_number
       parameter into TaskInstance.log_url method
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue.
   
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services