You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Karl Heinz Marbaise (Jira)" <ji...@apache.org> on 2020/03/27 14:43:00 UTC
[jira] [Commented] (MSHARED-869) Reduce duplication in
DefaultDependencyCollector-s
[ https://issues.apache.org/jira/browse/MSHARED-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068776#comment-17068776 ]
Karl Heinz Marbaise commented on MSHARED-869:
---------------------------------------------
Done in [641cee6a4cf505c82763677c83b40cab067325d1|https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=641cee6a4cf505c82763677c83b40cab067325d1]
> Reduce duplication in DefaultDependencyCollector-s
> --------------------------------------------------
>
> Key: MSHARED-869
> URL: https://issues.apache.org/jira/browse/MSHARED-869
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-artifact-transfer
> Affects Versions: maven-artifact-transfer-0.12.0
> Reporter: Piotr Zygielo
> Assignee: Karl Heinz Marbaise
> Priority: Trivial
>
> Parameter validation logic in {{o.a.m.s.transfer.collection.internal.DefaultDependencyCollector}}
> and
> {{o.a.m.s.transfer.dependencies.collect.internal.DefaultDependencyCollector}} could be extracted to common methods. It'd also allow to avoid duplicated "The parameter root is not allowed to be null." literals (to per-classs).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)