You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/28 18:43:03 UTC
[GitHub] [incubator-devlake] e2corporation opened a new pull request, #3247: fix: config-ui: prevent autofill of passwords on new connection form
e2corporation opened a new pull request, #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247
### Config-UI / Data Connections / **New Connection**
- [x] `Fix` set `autoComplete` to `new-password` mode for **Password** Type fields
### Description
This PR applies an update to Password type fields on the Connection form so that the `autoComplete` attribute is properly respected. This will prevent certain browsers like Firefox from forcibly entering default values for login and password fields when creating a new connection.
For additional reference on how autoComplete attribute is used, please see https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion
### Does this close any open issues?
Closes #3241
### Screenshots
<img width="1133" alt="Screen Shot 2022-09-28 at 2 41 17 PM" src="https://user-images.githubusercontent.com/1742233/192862924-db21f794-f234-40ad-9270-45992012f4fc.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1262308097
> 
>
> 'new-password' seems new password will show. And I find autoComplete="false" used in some other codes. Let's fix all of these in one PR?
I think i covered all the uses of `autoComplete`, _except_ for the `GenerateTokenForm` which is a legacy component for when we offered Base64 encoding for JIRA so that component is not actively being used at the moment so I didn't change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
likyh commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1261662834
'new-password' seems new password will show. And I find autoComplete="false" used in some other codes. Let's fix all of these in one PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1263599607
Converting this PR to **Draft** until this issue is further inspected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1261932117
@e2corporation Hi, Julien, I don't think this modification can completely solve the problem, it will cause firefox to incorrectly fill in the information elsewhere.
I don't think we should revise this, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
likyh commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1263114777
This PR seems not to block user and there are some disputes. Let's edit it until it fixed. Needn't limit on this Millstone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation closed pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
e2corporation closed pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
URL: https://github.com/apache/incubator-devlake/pull/3247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mintsweet commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1262997306
@e2corporation Hi, Julien.
When I autofill to firefox with my current code like this(username and password are filled):
When I modify the **autoComplete** of username to **new-password** (endpoint and password are filled):
This is very unexpected, I think this is a firefox problem, we don't need to write hack code to be compatible with firefox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form
Posted by GitBox <gi...@apache.org>.
e2corporation commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1262414758
> @e2corporation Hi, Julien, I don't think this modification can completely solve the problem, it will cause firefox to incorrectly fill in the information elsewhere.
>
> I don't think we should revise this, what do you think?
Can you demonstrate the breakage `new-password` is causing for you? I tested it on local Firefox it appears to be respecting the setting and not auto-filling passwords like Louis was experiencing.
As this is a Browser-induced issue I am also fine with not applying a fix if it's not necessary. In either case we still should modify the `autoComplete` property since `false` is not a desired setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org