You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Ma Xiaoguang <ma...@gmail.com> on 2019/01/28 09:46:43 UTC
discuss dubbo support opentracing
Re: discuss dubbo support opentracing
Posted by Kun Song <so...@gmail.com>.
Agree to put it in a specific repo, the main repo should be focused.
> 在 2019年1月29日，下午10:34，Huxing Zhang <hu...@apache.org> 写道：
>
> Hi,
>
> On Tue, Jan 29, 2019 at 4:40 PM Xiaoguang Ma <maxiaoguang@apache.org <ma...@apache.org>> wrote:
>>
>> I find a issue #3209 <https://github.com/apache/incubator-dubbo/issues/3209 <https://github.com/apache/incubator-dubbo/issues/3209>> in
>> github.
>> I have some experience in opentracing.
>> So I want to do it.
>> I will provider a filter that implement org.apache.dubbo.rpc.Filter and use
>> opentracing api.
>> Can i do it?
>
> +1 for support open-tracing. Embracing the standard is one of the
> things Dubbo would love to do.
> If you want to implement it, please feel free to go ahead.
>
> My questions is where should the codes be placed.
> Currently the implementation of Zipkin and Skywalking support are not
> in Dubbo's core repository.
> I think the core repository should focus on RPC implementation and extensions.
> If we put the code in, should we put Zipkin and Skywalking too?
> I prefer to put it somewhere outside of core repository. For example,
> a dedicate repository called dubbo-opentracing.
>
> Let's see how others think.
>
>>
>> Xiaoguang Ma from ShardingSphere
>>
>>
>> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道：
>>
>>> Hi,
>>>
>>> Would you please elaborate what you want to discuss here?
>>>
>>> On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com>
>>> wrote:
>>>
>>>
>>>
>>> --
>>> Best Regards！
>>> Huxing
>>>
>
>
>
> --
> Best Regards！
> Huxing
Re: discuss dubbo support opentracing
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Tue, Jan 29, 2019 at 4:40 PM Xiaoguang Ma <ma...@apache.org> wrote:
>
> I find a issue #3209 <https://github.com/apache/incubator-dubbo/issues/3209> in
> github.
> I have some experience in opentracing.
> So I want to do it.
> I will provider a filter that implement org.apache.dubbo.rpc.Filter and use
> opentracing api.
> Can i do it?
+1 for support open-tracing. Embracing the standard is one of the
things Dubbo would love to do.
If you want to implement it, please feel free to go ahead.
My questions is where should the codes be placed.
Currently the implementation of Zipkin and Skywalking support are not
in Dubbo's core repository.
I think the core repository should focus on RPC implementation and extensions.
If we put the code in, should we put Zipkin and Skywalking too?
I prefer to put it somewhere outside of core repository. For example,
a dedicate repository called dubbo-opentracing.
Let's see how others think.
>
> Xiaoguang Ma from ShardingSphere
>
>
> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道：
>
> > Hi,
> >
> > Would you please elaborate what you want to discuss here?
> >
> > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com>
> > wrote:
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
--
Best Regards！
Huxing
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
thanks Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 03/01/2019 13:42, Ian Luo wrote: Xiaoguang, I took a glance at issue's description and figured out @chickenlj is familiar at this area. I've assigned the issue to him. You may need to discuss further with him on this issue. Thanks, -Ian. On Thu, Feb 28, 2019 at 11:42 AM Xiaoguang Ma <ma...@apache.org> wrote: > i create a issue #3576 Xiaoguang Ma Apache ShardingSphere Signature is > customized by Netease Mail Master On 02/25/2019 16:05, Ian Luo wrote: > Xiaoguang, Your email is not plain-text friendly, therefore somehow hard to > read. Would you mind to file an issue to describe it? Thanks, -Ian. On Mon, > Feb 25, 2019 at 11:13 AM Xiaoguang Ma <ma...@apache.org> wrote: > > In image, result.hasException call future.get Xiaoguang Ma > Apache > ShardingSphere Signature is customized by Netease Mail Master On > > 02/25/2019 10:26, Ian Luo wrote: Xiaoguang, Would you mind to provide us > > more infos on async call not working on zipkin plugin? You may consider to > > file an issue first where you can describe the issue better and provide > the > concrete steps to reproduce it. Thanks, -Ian. On Fri, Feb 22, 2019 at > 5:54 > PM Xiaoguang Ma <ma...@apache.org> wrote: > async call not > work in > zipkin plugin. > zipkin plugin support dubbo2.7. > > can we talk > about it > > > > > Xiaoguang Ma > Apache ShardingSphere > > < > > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Xiaoguang+Ma&uid=maxiaoguang%40apache.org&position=Apache%C2%A0ShardingSphere>;;; > > > > Signature is customized by Netease Mail Master > < > > https://mail.163.com/dashi/dlpro.html?from=mail88>;;; > > On 01/30/2019 > > 17:22, Xiaoguang Ma <ma...@apache.org> wrote: > Opentracing org > > already agree and promise to review. Now, I am doing in my > repository. > > Xiaoguang Ma Apache ShardingSphere Signature is customized by > Netease > > Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can > start > > your work in github.com/dubbo for now, then you can approach > > > opentracing org to check if they are willing to accept your work. I can > > > create a new project in dubbo group [1] for your experiment. Thanks, -Ian. > > > 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma < > > > maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing > whether > > I can push this in opentracing > repository or not > > Ma > Xiaoguang > > > Apache ShardingSphere > > > maxiaoguang < > maxiaoguang@apache.org> > > 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and > skywalking also support > > opentracing. > > > > > > > > Ma Xiaoguang > > > Apache ShardingSphere > > > > > > < > > > > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > > > > Signature is customized by Netease Mail Master > > < > > > https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On > > > 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently > > > there is a filter in brave to support integration with zipkin > > > > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > > > > But provide a integration with opentracing api directly, it may > > > give more > > choice for users. > > > > On 2019/01/29 08:39:52, > Xiaoguang > > Ma <ma...@apache.org> wrote: > > > I find a issue > #3209 < > > > > https://github.com/apache/incubator-dubbo/issues/3209> > in > > > > > github. > > > I have some experience in opentracing. > > > So > I want to do > > it. > > > I will provider a filter that implement > > > org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i > > > do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss > > > here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > > > > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Ian Luo <ia...@gmail.com>.
Xiaoguang,
I took a glance at issue's description and figured out @chickenlj is
familiar at this area. I've assigned the issue to him. You may need to
discuss further with him on this issue.
Thanks,
-Ian.
On Thu, Feb 28, 2019 at 11:42 AM Xiaoguang Ma <ma...@apache.org>
wrote:
> i create a issue #3576 Xiaoguang Ma Apache ShardingSphere Signature is
> customized by Netease Mail Master On 02/25/2019 16:05, Ian Luo wrote:
> Xiaoguang, Your email is not plain-text friendly, therefore somehow hard to
> read. Would you mind to file an issue to describe it? Thanks, -Ian. On Mon,
> Feb 25, 2019 at 11:13 AM Xiaoguang Ma <ma...@apache.org> wrote: >
> In image, result.hasException call future.get Xiaoguang Ma > Apache
> ShardingSphere Signature is customized by Netease Mail Master On >
> 02/25/2019 10:26, Ian Luo wrote: Xiaoguang, Would you mind to provide us >
> more infos on async call not working on zipkin plugin? You may consider to
> > file an issue first where you can describe the issue better and provide
> the > concrete steps to reproduce it. Thanks, -Ian. On Fri, Feb 22, 2019 at
> 5:54 > PM Xiaoguang Ma <ma...@apache.org> wrote: > async call not
> work in > zipkin plugin. > zipkin plugin support dubbo2.7. > > can we talk
> about it > > > > > Xiaoguang Ma > Apache ShardingSphere > > < >
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Xiaoguang+Ma&uid=maxiaoguang%40apache.org&position=Apache%C2%A0ShardingSphere>;;
> > > > Signature is customized by Netease Mail Master > < >
> https://mail.163.com/dashi/dlpro.html?from=mail88>;; > > On 01/30/2019 >
> 17:22, Xiaoguang Ma <ma...@apache.org> wrote: > Opentracing org >
> already agree and promise to review. Now, I am doing in my > repository. >
> Xiaoguang Ma Apache ShardingSphere Signature is customized by > Netease >
> Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can > start
> > your work in github.com/dubbo for now, then you can approach > >
> opentracing org to check if they are willing to accept your work. I can > >
> create a new project in dubbo group [1] for your experiment. Thanks, -Ian.
> > > 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma < >
> > maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing
> whether > > I can push this in opentracing > repository or not > > Ma
> Xiaoguang > > > Apache ShardingSphere > > > maxiaoguang <
> maxiaoguang@apache.org> > > 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and
> skywalking also support > > opentracing. > > > > > > > > Ma Xiaoguang > >
> Apache ShardingSphere > > > > > > < > > >
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D
> > > > > > > > > Signature is customized by Netease Mail Master > > < > >
> https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On > >
> 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently >
> > there is a filter in brave to support integration with zipkin > > > > >
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
> > > > > > > But provide a integration with opentracing api directly, it may
> > > give more > > choice for users. > > > > On 2019/01/29 08:39:52,
> Xiaoguang > > Ma <ma...@apache.org> wrote: > > > I find a issue
> #3209 < > > > > https://github.com/apache/incubator-dubbo/issues/3209>
> in > > > > > github. > > > I have some experience in opentracing. > > > So
> I want to do > > it. > > > I will provider a filter that implement > >
> org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i
> > > do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > >
> > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > >
> > > Hi, > > > > > > > > Would you please elaborate what you want to discuss
> > > here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < >
> > > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > >
> > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > > >
> >
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
i create a issue #3576 Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 02/25/2019 16:05, Ian Luo wrote: Xiaoguang, Your email is not plain-text friendly, therefore somehow hard to read. Would you mind to file an issue to describe it? Thanks, -Ian. On Mon, Feb 25, 2019 at 11:13 AM Xiaoguang Ma <ma...@apache.org> wrote: > In image, result.hasException call future.get Xiaoguang Ma > Apache ShardingSphere Signature is customized by Netease Mail Master On > 02/25/2019 10:26, Ian Luo wrote: Xiaoguang, Would you mind to provide us > more infos on async call not working on zipkin plugin? You may consider to > file an issue first where you can describe the issue better and provide the > concrete steps to reproduce it. Thanks, -Ian. On Fri, Feb 22, 2019 at 5:54 > PM Xiaoguang Ma <ma...@apache.org> wrote: > async call not work in > zipkin plugin. > zipkin plugin support dubbo2.7. > > can we talk about it > > > > > Xiaoguang Ma > Apache ShardingSphere > > < > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Xiaoguang+Ma&uid=maxiaoguang%40apache.org&position=Apache%C2%A0ShardingSphere>;; > > > Signature is customized by Netease Mail Master > < > https://mail.163.com/dashi/dlpro.html?from=mail88>;; > > On 01/30/2019 > 17:22, Xiaoguang Ma <ma...@apache.org> wrote: > Opentracing org > already agree and promise to review. Now, I am doing in my > repository. > Xiaoguang Ma Apache ShardingSphere Signature is customized by > Netease > Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can > start > your work in github.com/dubbo for now, then you can approach > > opentracing org to check if they are willing to accept your work. I can > > create a new project in dubbo group [1] for your experiment. Thanks, -Ian. > > 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma < > > maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing whether > > I can push this in opentracing > repository or not > > Ma Xiaoguang > > > Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> > > 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support > > opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > > > > < > > > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > > > Signature is customized by Netease Mail Master > > < > > https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On > > 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently > > there is a filter in brave to support integration with zipkin > > > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > > > But provide a integration with opentracing api directly, it may > > give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang > > Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > > > https://github.com/apache/incubator-dubbo/issues/3209> in > > > > > github. > > > I have some experience in opentracing. > > > So I want to do > > it. > > > I will provider a filter that implement > > org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i > > do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss > > here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > > > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Ian Luo <ia...@gmail.com>.
Xiaoguang,
Your email is not plain-text friendly, therefore somehow hard to read.
Would you mind to file an issue to describe it?
Thanks,
-Ian.
On Mon, Feb 25, 2019 at 11:13 AM Xiaoguang Ma <ma...@apache.org>
wrote:
> In image, result.hasException call future.get Xiaoguang Ma
> Apache ShardingSphere Signature is customized by Netease Mail Master On
> 02/25/2019 10:26, Ian Luo wrote: Xiaoguang, Would you mind to provide us
> more infos on async call not working on zipkin plugin? You may consider to
> file an issue first where you can describe the issue better and provide the
> concrete steps to reproduce it. Thanks, -Ian. On Fri, Feb 22, 2019 at 5:54
> PM Xiaoguang Ma <ma...@apache.org> wrote: > async call not work in
> zipkin plugin. > zipkin plugin support dubbo2.7. > > can we talk about it >
> > > > Xiaoguang Ma > Apache ShardingSphere > > <
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Xiaoguang+Ma&uid=maxiaoguang%40apache.org&position=Apache%C2%A0ShardingSphere>;
> > > Signature is customized by Netease Mail Master > <
> https://mail.163.com/dashi/dlpro.html?from=mail88>; > > On 01/30/2019
> 17:22, Xiaoguang Ma <ma...@apache.org> wrote: > Opentracing org
> already agree and promise to review. Now, I am doing in my > repository.
> Xiaoguang Ma Apache ShardingSphere Signature is customized by > Netease
> Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can > start
> your work in github.com/dubbo for now, then you can approach >
> opentracing org to check if they are willing to accept your work. I can >
> create a new project in dubbo group [1] for your experiment. Thanks, -Ian.
> > 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma < >
> maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing whether
> > I can push this in opentracing > repository or not > > Ma Xiaoguang > >
> Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> >
> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support >
> opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > >
> > < > >
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D
> > > > > > > > Signature is customized by Netease Mail Master > > < >
> https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On >
> 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently >
> there is a filter in brave to support integration with zipkin > > > >
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
> > > > > > But provide a integration with opentracing api directly, it may >
> give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang >
> Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > >
> https://github.com/apache/incubator-dubbo/issues/3209> in > > > >
> github. > > > I have some experience in opentracing. > > > So I want to do
> > it. > > > I will provider a filter that implement >
> org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i
> > do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > >
> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > >
> Hi, > > > > > > > > Would you please elaborate what you want to discuss >
> here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > >
> maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > >
> > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
In image, result.hasException call future.get Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 02/25/2019 10:26, Ian Luo wrote: Xiaoguang, Would you mind to provide us more infos on async call not working on zipkin plugin? You may consider to file an issue first where you can describe the issue better and provide the concrete steps to reproduce it. Thanks, -Ian. On Fri, Feb 22, 2019 at 5:54 PM Xiaoguang Ma <ma...@apache.org> wrote: > async call not work in zipkin plugin. > zipkin plugin support dubbo2.7. > > can we talk about it > > > > Xiaoguang Ma > Apache ShardingSphere > > <https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Xiaoguang+Ma&uid=maxiaoguang%40apache.org&position=Apache%C2%A0ShardingSphere>; > > Signature is customized by Netease Mail Master > <https://mail.163.com/dashi/dlpro.html?from=mail88>; > > On 01/30/2019 17:22, Xiaoguang Ma <ma...@apache.org> wrote: > Opentracing org already agree and promise to review. Now, I am doing in my > repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by > Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can > start your work in github.com/dubbo for now, then you can approach > opentracing org to check if they are willing to accept your work. I can > create a new project in dubbo group [1] for your experiment. Thanks, -Ian. > 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma < > maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing whether > I can push this in opentracing > repository or not > > Ma Xiaoguang > > Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> > 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support > opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > > > < > > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > > Signature is customized by Netease Mail Master > > < > https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On > 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently > there is a filter in brave to support integration with zipkin > > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > > But provide a integration with opentracing api directly, it may > give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang > Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > > https://github.com/apache/incubator-dubbo/issues/3209> in > > > > github. > > > I have some experience in opentracing. > > > So I want to do > it. > > > I will provider a filter that implement > org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i > do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss > here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Ian Luo <ia...@gmail.com>.
Xiaoguang,
Would you mind to provide us more infos on async call not working on zipkin
plugin? You may consider to file an issue first where you can describe the
issue better and provide the concrete steps to reproduce it.
Thanks,
-Ian.
On Fri, Feb 22, 2019 at 5:54 PM Xiaoguang Ma <ma...@apache.org> wrote:
> async call not work in zipkin plugin.
> zipkin plugin support dubbo2.7.
>
> can we talk about it
>
>
>
> Xiaoguang Ma
> Apache ShardingSphere
>
> <https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Xiaoguang+Ma&uid=maxiaoguang%40apache.org&position=Apache%C2%A0ShardingSphere>
>
> Signature is customized by Netease Mail Master
> <https://mail.163.com/dashi/dlpro.html?from=mail88>
>
> On 01/30/2019 17:22, Xiaoguang Ma <ma...@apache.org> wrote:
> Opentracing org already agree and promise to review. Now, I am doing in my
> repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by
> Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can
> start your work in github.com/dubbo for now, then you can approach
> opentracing org to check if they are willing to accept your work. I can
> create a new project in dubbo group [1] for your experiment. Thanks, -Ian.
> 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <
> maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing whether
> I can push this in opentracing > repository or not > > Ma Xiaoguang >
> Apache ShardingSphere > > > maxiaoguang <ma...@apache.org>
> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support
> opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > >
> < >
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D
> > > > > > > Signature is customized by Netease Mail Master > > <
> https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On
> 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently
> there is a filter in brave to support integration with zipkin > > >
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
> > > > > But provide a integration with opentracing api directly, it may
> give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang
> Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > >
> https://github.com/apache/incubator-dubbo/issues/3209> in > > >
> github. > > > I have some experience in opentracing. > > > So I want to do
> it. > > > I will provider a filter that implement
> org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i
> do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > >
> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > >
> Hi, > > > > > > > > Would you please elaborate what you want to discuss
> here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < >
> maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > >
> > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > >
>
>
Re: discuss dubbo support opentracing
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
On Mon, Mar 25, 2019 at 1:50 PM Adrian Cole <ad...@apache.org> wrote:
>
> Hi, I think this is a strange thing to do.
What strange thing?
>
> Zipkin community have been maintaining support for the prior project. We cannot delete that without burdening your existing users. We asked for guidance on how to support moving forward. One way is to change the artifact name as things here are now binary incompatible.
Please state what specifically issue did you encountered.
2.7.0 renames the package name to org.apache, but the goal is not to
break the compatibility. Instead, the Dubbo community would like to
maintain the compatibility as much as possible, but it is known that
it is not 100% compatible. Yes, the community has received several
reports of incompatibility. If there is an issue, please file it so
the community would take a look and hopefully to fix it.
>
> https://github.com/openzipkin/brave/issues/867
>
> I would hope you can in the future look at our attempts to keep continuity in your own community as a benefit vs a reason to stop working with us.
Dubbo community never decide to stop working with some other
community. Supporting open tracing does not mean stop working with
zipkin.
>
> -Adrian
>
>
> On 2019/02/22 09:54:33, Xiaoguang Ma <ma...@apache.org> wrote:
> > async call not work in zipkin plugin. zipkin plugin support dubbo2.7. can we talk about it Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 17:22, Xiaoguang Ma wrote: Opentracing org already agree and promise to review. Now, I am doing in my repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can start your work in github.com/dubbo for now, then you can approach opentracing org to check if they are willing to accept your work. I can create a new project in dubbo group [1] for your experiment. Thanks, -Ian. 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <ma...@apache.org> wrote: > Ok, I try to connect opentracing whether I can push this in opentracing > repository or not > > Ma Xiaoguang > Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > > < > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > Signature is customized by Netease Mail Master > > <https://mail.163.com/dashi/dlpro.html?from=mail88>;; > > > > On 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently there is a filter in brave to support integration with zipkin > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > But provide a integration with opentracing api directly, it may give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > https://github.com/apache/incubator-dubbo/issues/3209> in > > > github. > > > I have some experience in opentracing. > > > So I want to do it. > > > I will provider a filter that implement org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > >
--
Best Regards！
Huxing
Re: discuss dubbo support opentracing
Posted by Ian Luo <ia...@gmail.com>.
Adrian,
Your concern is noted [1]. We will try to address this particular
incompatibility issue in 2.7.2 release.
Thanks,
-Ian.
1. https://github.com/apache/incubator-dubbo/issues/3728
On Mon, Mar 25, 2019 at 1:50 PM Adrian Cole <ad...@apache.org> wrote:
> Hi, I think this is a strange thing to do.
>
> Zipkin community have been maintaining support for the prior project. We
> cannot delete that without burdening your existing users. We asked for
> guidance on how to support moving forward. One way is to change the
> artifact name as things here are now binary incompatible.
>
> https://github.com/openzipkin/brave/issues/867
>
> I would hope you can in the future look at our attempts to keep continuity
> in your own community as a benefit vs a reason to stop working with us.
>
> -Adrian
>
>
> On 2019/02/22 09:54:33, Xiaoguang Ma <ma...@apache.org> wrote:
> > async call not work in zipkin plugin. zipkin plugin support dubbo2.7.
> can we talk about it Xiaoguang Ma Apache ShardingSphere Signature is
> customized by Netease Mail Master On 01/30/2019 17:22, Xiaoguang Ma wrote:
> Opentracing org already agree and promise to review. Now, I am doing in my
> repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by
> Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can
> start your work in github.com/dubbo for now, then you can approach
> opentracing org to check if they are willing to accept your work. I can
> create a new project in dubbo group [1] for your experiment. Thanks, -Ian.
> 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <
> maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing whether
> I can push this in opentracing > repository or not > > Ma Xiaoguang >
> Apache ShardingSphere > > > maxiaoguang <ma...@apache.org>
> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support
> opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > >
> < >
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D
> > > > > > > Signature is customized by Netease Mail Master > > <
> https://mail.163.com/dashi/dlpro.html?from=mail88>;; > > > > On
> 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently
> there is a filter in brave to support integration with zipkin > > >
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
> > > > > But provide a integration with opentracing api directly, it may
> give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang
> Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > >
> https://github.com/apache/incubator-dubbo/issues/3209> in > > > github. >
> > > I have some experience in opentracing. > > > So I want to do it. > > >
> I will provider a filter that implement org.apache.dubbo.rpc.Filter and > >
> use > > > opentracing api. > > > Can i do it? > > > > > > Xiaoguang Ma from
> ShardingSphere > > > > > > > > > Huxing Zhang <hu...@apache.org>
> 于2019年1月29日周二 下午4:13写道： > > > > > > > Hi, > > > > > > > > Would you please
> elaborate what you want to discuss here? > > > > > > > > On Mon, Jan 28,
> 2019 at 5:46 PM Ma Xiaoguang < > maxiaoguang64@gmail.com> > > > > > >
> wrote: > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > >
> Huxing > > > > > > > > > > > >
>
Re: discuss dubbo support opentracing
Posted by Adrian Cole <ad...@apache.org>.
Hi, I think this is a strange thing to do.
Zipkin community have been maintaining support for the prior project. We cannot delete that without burdening your existing users. We asked for guidance on how to support moving forward. One way is to change the artifact name as things here are now binary incompatible.
https://github.com/openzipkin/brave/issues/867
I would hope you can in the future look at our attempts to keep continuity in your own community as a benefit vs a reason to stop working with us.
-Adrian
On 2019/02/22 09:54:33, Xiaoguang Ma <ma...@apache.org> wrote:
> async call not work in zipkin plugin. zipkin plugin support dubbo2.7. can we talk about it Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 17:22, Xiaoguang Ma wrote: Opentracing org already agree and promise to review. Now, I am doing in my repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can start your work in github.com/dubbo for now, then you can approach opentracing org to check if they are willing to accept your work. I can create a new project in dubbo group [1] for your experiment. Thanks, -Ian. 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <ma...@apache.org> wrote: > Ok, I try to connect opentracing whether I can push this in opentracing > repository or not > > Ma Xiaoguang > Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > > < > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > Signature is customized by Netease Mail Master > > <https://mail.163.com/dashi/dlpro.html?from=mail88>;; > > > > On 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently there is a filter in brave to support integration with zipkin > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > But provide a integration with opentracing api directly, it may give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > https://github.com/apache/incubator-dubbo/issues/3209> in > > > github. > > > I have some experience in opentracing. > > > So I want to do it. > > > I will provider a filter that implement org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
async call not work in zipkin plugin. zipkin plugin support dubbo2.7. can we talk about it Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 17:22, Xiaoguang Ma wrote: Opentracing org already agree and promise to review. Now, I am doing in my repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can start your work in github.com/dubbo for now, then you can approach opentracing org to check if they are willing to accept your work. I can create a new project in dubbo group [1] for your experiment. Thanks, -Ian. 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <ma...@apache.org> wrote: > Ok, I try to connect opentracing whether I can push this in opentracing > repository or not > > Ma Xiaoguang > Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > > < > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > Signature is customized by Netease Mail Master > > <https://mail.163.com/dashi/dlpro.html?from=mail88>;; > > > > On 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently there is a filter in brave to support integration with zipkin > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > But provide a integration with opentracing api directly, it may give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > https://github.com/apache/incubator-dubbo/issues/3209> in > > > github. > > > I have some experience in opentracing. > > > So I want to do it. > > > I will provider a filter that implement org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Ian Luo <ia...@gmail.com>.
sounds great, pls. keep us posted.
-Ian.
On Wed, Jan 30, 2019 at 5:22 PM Xiaoguang Ma <ma...@apache.org> wrote:
> Opentracing org already agree and promise to review. Now, I am doing in my
> repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by
> Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can
> start your work in github.com/dubbo for now, then you can approach
> opentracing org to check if they are willing to accept your work. I can
> create a new project in dubbo group [1] for your experiment. Thanks, -Ian.
> 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <
> maxiaoguang@apache.org> wrote: > Ok, I try to connect opentracing whether
> I can push this in opentracing > repository or not > > Ma Xiaoguang >
> Apache ShardingSphere > > > maxiaoguang <ma...@apache.org>
> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support
> opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > >
> < >
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D
> > > > > > > Signature is customized by Netease Mail Master > > <
> https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On 01/29/2019
> 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently there is a
> filter in brave to support integration with zipkin > > >
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
> > > > > But provide a integration with opentracing api directly, it may
> give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang
> Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > >
> https://github.com/apache/incubator-dubbo/issues/3209> in > > >
> github. > > > I have some experience in opentracing. > > > So I want to do
> it. > > > I will provider a filter that implement
> org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i
> do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > >
> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > >
> Hi, > > > > > > > > Would you please elaborate what you want to discuss
> here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < >
> maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > >
> > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
Opentracing org already agree and promise to review. Now, I am doing in my repository. Xiaoguang Ma Apache ShardingSphere Signature is customized by Netease Mail Master On 01/30/2019 14:50, Ian Luo wrote: Xiaoguang, You can start your work in github.com/dubbo for now, then you can approach opentracing org to check if they are willing to accept your work. I can create a new project in dubbo group [1] for your experiment. Thanks, -Ian. 1. github.com/dubbo On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <ma...@apache.org> wrote: > Ok, I try to connect opentracing whether I can push this in opentracing > repository or not > > Ma Xiaoguang > Apache ShardingSphere > > > maxiaoguang <ma...@apache.org> 于2019年1月30日周三 上午9:49写道： > > > Yes, zipkin and skywalking also support opentracing. > > > > > > > > Ma Xiaoguang > > Apache ShardingSphere > > > > < > https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D > > > > > > Signature is customized by Netease Mail Master > > <https://mail.163.com/dashi/dlpro.html?from=mail88>; > > > > On 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote: > > Currently there is a filter in brave to support integration with zipkin > > > https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc > > > > But provide a integration with opentracing api directly, it may give more > > choice for users. > > > > On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote: > > > I find a issue #3209 < > > https://github.com/apache/incubator-dubbo/issues/3209> in > > > github. > > > I have some experience in opentracing. > > > So I want to do it. > > > I will provider a filter that implement org.apache.dubbo.rpc.Filter and > > use > > > opentracing api. > > > Can i do it? > > > > > > Xiaoguang Ma from ShardingSphere > > > > > > > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > > > > > Hi, > > > > > > > > Would you please elaborate what you want to discuss here? > > > > > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang < > maxiaoguang64@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > -- > > > > Best Regards！ > > > > Huxing > > > > > > > > > > > >
Re: discuss dubbo support opentracing
Posted by Ian Luo <ia...@gmail.com>.
Xiaoguang,
You can start your work in github.com/dubbo for now, then you can approach
opentracing org to check if they are willing to accept your work. I can
create a new project in dubbo group [1] for your experiment.
Thanks,
-Ian.
1. github.com/dubbo
On Wed, Jan 30, 2019 at 10:03 AM Xiaoguang Ma <ma...@apache.org>
wrote:
> Ok, I try to connect opentracing whether I can push this in opentracing
> repository or not
>
> Ma Xiaoguang
> Apache ShardingSphere
>
>
> maxiaoguang <ma...@apache.org> 于2019年1月30日周三 上午9:49写道：
>
> > Yes, zipkin and skywalking also support opentracing.
> >
> >
> >
> > Ma Xiaoguang
> > Apache ShardingSphere
> >
> > <
> https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D
> >
> >
> > Signature is customized by Netease Mail Master
> > <https://mail.163.com/dashi/dlpro.html?from=mail88>
> >
> > On 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote:
> > Currently there is a filter in brave to support integration with zipkin
> >
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
> >
> > But provide a integration with opentracing api directly, it may give more
> > choice for users.
> >
> > On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote:
> > > I find a issue #3209 <
> > https://github.com/apache/incubator-dubbo/issues/3209> in
> > > github.
> > > I have some experience in opentracing.
> > > So I want to do it.
> > > I will provider a filter that implement org.apache.dubbo.rpc.Filter and
> > use
> > > opentracing api.
> > > Can i do it?
> > >
> > > Xiaoguang Ma from ShardingSphere
> > >
> > >
> > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道：
> > >
> > > > Hi,
> > > >
> > > > Would you please elaborate what you want to discuss here?
> > > >
> > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <
> maxiaoguang64@gmail.com>
> >
> > > > wrote:
> > > >
> > > >
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
> >
> >
>
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
Ok, I try to connect opentracing whether I can push this in opentracing
repository or not
Ma Xiaoguang
Apache ShardingSphere
maxiaoguang <ma...@apache.org> 于2019年1月30日周三 上午9:49写道：
> Yes, zipkin and skywalking also support opentracing.
>
>
>
> Ma Xiaoguang
> Apache ShardingSphere
>
> <https://maas.mail.163.com/dashi-web-extend/html/proSignature.html?ftlId=2&name=Ma+Xiaoguang&uid=maxiaoguang64%40gmail.com&position=Apache%C2%A0ShardingSphere&items=%5B%22%22%5D>
>
> Signature is customized by Netease Mail Master
> <https://mail.163.com/dashi/dlpro.html?from=mail88>
>
> On 01/29/2019 17:20, Yunkun Huang <ht...@gmail.com> wrote:
> Currently there is a filter in brave to support integration with zipkin
> https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
>
> But provide a integration with opentracing api directly, it may give more
> choice for users.
>
> On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote:
> > I find a issue #3209 <
> https://github.com/apache/incubator-dubbo/issues/3209> in
> > github.
> > I have some experience in opentracing.
> > So I want to do it.
> > I will provider a filter that implement org.apache.dubbo.rpc.Filter and
> use
> > opentracing api.
> > Can i do it?
> >
> > Xiaoguang Ma from ShardingSphere
> >
> >
> > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道：
> >
> > > Hi,
> > >
> > > Would you please elaborate what you want to discuss here?
> > >
> > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com>
>
> > > wrote:
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
>
>
Re: discuss dubbo support opentracing
Posted by Ma Xiaoguang <ma...@apache.org>.
Yes, zipkin and skywalking also support opentracing. Ma Xiaoguang Apache ShardingSphere Signature is customized by Netease Mail Master On 01/29/2019 17:20, Yunkun Huang wrote: Currently there is a filter in brave to support integration with zipkin https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc But provide a integration with opentracing api directly, it may give more choice for users. On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote: > I find a issue #3209 <https://github.com/apache/incubator-dubbo/issues/3209>; in > github. > I have some experience in opentracing. > So I want to do it. > I will provider a filter that implement org.apache.dubbo.rpc.Filter and use > opentracing api. > Can i do it? > > Xiaoguang Ma from ShardingSphere > > > Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道： > > > Hi, > > > > Would you please elaborate what you want to discuss here? > > > > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com> > > wrote: > > > > > > > > -- > > Best Regards！ > > Huxing > > >
Re: discuss dubbo support opentracing
Posted by Yunkun Huang <ht...@gmail.com>.
Currently there is a filter in brave to support integration with zipkin
https://github.com/openzipkin/brave/tree/master/instrumentation/dubbo-rpc
But provide a integration with opentracing api directly, it may give more choice for users.
On 2019/01/29 08:39:52, Xiaoguang Ma <ma...@apache.org> wrote:
> I find a issue #3209 <https://github.com/apache/incubator-dubbo/issues/3209> in
> github.
> I have some experience in opentracing.
> So I want to do it.
> I will provider a filter that implement org.apache.dubbo.rpc.Filter and use
> opentracing api.
> Can i do it?
>
> Xiaoguang Ma from ShardingSphere
>
>
> Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道：
>
> > Hi,
> >
> > Would you please elaborate what you want to discuss here?
> >
> > On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com>
> > wrote:
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>
Re: discuss dubbo support opentracing
Posted by Xiaoguang Ma <ma...@apache.org>.
I find a issue #3209 <https://github.com/apache/incubator-dubbo/issues/3209> in
github.
I have some experience in opentracing.
So I want to do it.
I will provider a filter that implement org.apache.dubbo.rpc.Filter and use
opentracing api.
Can i do it?
Xiaoguang Ma from ShardingSphere
Huxing Zhang <hu...@apache.org> 于2019年1月29日周二 下午4:13写道：
> Hi,
>
> Would you please elaborate what you want to discuss here?
>
> On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com>
> wrote:
>
>
>
> --
> Best Regards！
> Huxing
>
Re: discuss dubbo support opentracing
Posted by Huxing Zhang <hu...@apache.org>.
Hi,
Would you please elaborate what you want to discuss here?
On Mon, Jan 28, 2019 at 5:46 PM Ma Xiaoguang <ma...@gmail.com> wrote:
--
Best Regards！
Huxing