[GitHub] spark pull request: [SPARK-1919] Fix Windows spark-shell --jars

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2211#discussion_r16966248
  
    --- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
    @@ -965,11 +966,9 @@ class SparkILoop(in0: Option[BufferedReader], protected val out: JPrintWriter,
     
       def createSparkContext(): SparkContext = {
         val execUri = System.getenv("SPARK_EXECUTOR_URI")
    -    val jars = SparkILoop.getAddedJars
         val conf = new SparkConf()
           .setMaster(getMaster())
           .setAppName("Spark shell")
    -      .setJars(jars)
    --- End diff --
    
    Hm yeah. Actually for this PR I think I'll just modify only the jar paths added to the classpath of the shell, but not worry about changing the value of `spark.jars` when different things are set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org