You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2017/10/28 16:18:38 UTC
[6/7] beam git commit: NonNull by default in
sdk/transforms/splittabledofn
NonNull by default in sdk/transforms/splittabledofn
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/82fc7208
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/82fc7208
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/82fc7208
Branch: refs/heads/master
Commit: 82fc720808f75e84f8502f681b25560735dfa7f1
Parents: 7b2edb1
Author: Kenneth Knowles <kl...@google.com>
Authored: Thu Oct 26 06:57:55 2017 -0700
Committer: Kenneth Knowles <kl...@google.com>
Committed: Sat Oct 28 08:42:31 2017 -0700
----------------------------------------------------------------------
.../beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java | 5 +++--
.../apache/beam/sdk/transforms/splittabledofn/package-info.java | 4 ++++
2 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/82fc7208/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java
index 4987409..8ec2c6b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java
@@ -22,6 +22,7 @@ import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.base.Preconditions.checkState;
import com.google.common.base.MoreObjects;
+import javax.annotation.Nullable;
import org.apache.beam.sdk.io.range.OffsetRange;
import org.apache.beam.sdk.transforms.DoFn;
@@ -31,8 +32,8 @@ import org.apache.beam.sdk.transforms.DoFn;
*/
public class OffsetRangeTracker implements RestrictionTracker<OffsetRange> {
private OffsetRange range;
- private Long lastClaimedOffset = null;
- private Long lastAttemptedOffset = null;
+ @Nullable private Long lastClaimedOffset = null;
+ @Nullable private Long lastAttemptedOffset = null;
public OffsetRangeTracker(OffsetRange range) {
this.range = checkNotNull(range);
http://git-wip-us.apache.org/repos/asf/beam/blob/82fc7208/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java
index 4523032..82538ea 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/package-info.java
@@ -19,4 +19,8 @@
* Defines utilities related to <a href="https://s.apache.org/splittable-do-fn">splittable</a>
* {@link org.apache.beam.sdk.transforms.DoFn}.
*/
+@DefaultAnnotation(NonNull.class)
package org.apache.beam.sdk.transforms.splittabledofn;
+
+import edu.umd.cs.findbugs.annotations.DefaultAnnotation;
+import edu.umd.cs.findbugs.annotations.NonNull;