You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/13 06:10:11 UTC
[GitHub] [arrow] Crystrix opened a new pull request #10309: ARROW-12771: [C++][Compute] Fix MaybeReserve parameter in the Consume function of GroupedCountImpl
Crystrix opened a new pull request #10309:
URL: https://github.com/apache/arrow/pull/10309
The parameter of `MaybeReserve` in `GroupedCountImpl`'s `Consume` function is incorrect.
`counts_.length()` means the buffer's byte size, it should be replaced with `num_groups_`. Otherwise, subsequent chunked arrays with more groups are skipped as `counts_.length()` is actually `num_groups_*sizeof(int64_t)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10309: ARROW-12771: [C++][Compute] Fix MaybeReserve parameter in the Consume function of GroupedCountImpl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10309:
URL: https://github.com/apache/arrow/pull/10309#issuecomment-840333470
https://issues.apache.org/jira/browse/ARROW-12771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10309: ARROW-12771: [C++][Compute] Fix MaybeReserve parameter in the Consume function of GroupedCountImpl
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10309:
URL: https://github.com/apache/arrow/pull/10309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #10309: ARROW-12771: [C++][Compute] Fix MaybeReserve parameter in the Consume function of GroupedCountImpl
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #10309:
URL: https://github.com/apache/arrow/pull/10309#issuecomment-844146367
CI failures look unrelated. I've restarted the failed jobs, will merge when everything's green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org