You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2017/01/25 15:03:58 UTC
Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI Historical
SQL Operations section
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55932/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section
There is a race condition in the handling of the SQLOperationDisplay classes. Once an operation is complete/cancelled/timed out we move the SQLOperationDisplay from the live stack to the historical one. But the runtime is only updated once the state is set, after the SQLOperationDisplay is already among the historical queries.
With this change the runtime will be "n/a" instead of an NPE being thrown.
Diffs
-----
service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp 6e899819cf33e149cbb2dbffb201348408330bbc
Diff: https://reviews.apache.org/r/55932/diff/
Testing
-------
Ran multiple queries and checked that they are still displayed correctly.
Thanks,
Barna Zsombor Klara
Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI
Historical SQL Operations section
Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55932/#review163284
-----------------------------------------------------------
Ship it!
LGTM. +1
- Chaoyu Tang
On Jan. 25, 2017, 3:03 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55932/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 3:03 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section
> There is a race condition in the handling of the SQLOperationDisplay classes. Once an operation is complete/cancelled/timed out we move the SQLOperationDisplay from the live stack to the historical one. But the runtime is only updated once the state is set, after the SQLOperationDisplay is already among the historical queries.
> With this change the runtime will be "n/a" instead of an NPE being thrown.
>
>
> Diffs
> -----
>
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp 6e899819cf33e149cbb2dbffb201348408330bbc
>
> Diff: https://reviews.apache.org/r/55932/diff/
>
>
> Testing
> -------
>
> Ran multiple queries and checked that they are still displayed correctly.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI
Historical SQL Operations section
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55932/#review162964
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On Jan. 25, 2017, 3:03 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55932/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 3:03 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section
> There is a race condition in the handling of the SQLOperationDisplay classes. Once an operation is complete/cancelled/timed out we move the SQLOperationDisplay from the live stack to the historical one. But the runtime is only updated once the state is set, after the SQLOperationDisplay is already among the historical queries.
> With this change the runtime will be "n/a" instead of an NPE being thrown.
>
>
> Diffs
> -----
>
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp 6e899819cf33e149cbb2dbffb201348408330bbc
>
> Diff: https://reviews.apache.org/r/55932/diff/
>
>
> Testing
> -------
>
> Ran multiple queries and checked that they are still displayed correctly.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>