You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "JCelento (via GitHub)" <gi...@apache.org> on 2026/04/20 14:30:56 UTC

[PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

JCelento opened a new pull request, #39490:
URL: https://github.com/apache/superset/pull/39490

   ### SUMMARY
   
   When a chart has both a `row_limit` and `row_offset` set alongside time comparison offsets, the offset subqueries were ignoring the chart's own `row_limit` and always falling back to the global `ROW_LIMIT` from the instance config. This caused data inconsistency when joining the comparison dataframes, since the main query and its offset counterparts were fetching different numbers of rows.
   
   The fix makes offset subqueries inherit the chart's `row_limit` when one is set, and only falls back to `app.config["ROW_LIMIT"]` when the chart has a `row_offset` but no explicit `row_limit`.
   
   **Before:** offset subquery always used `app.config["ROW_LIMIT"]`
   **After:** offset subquery uses `query_object.row_limit or app.config["ROW_LIMIT"]`
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — backend query generation change.
   
   ### TESTING INSTRUCTIONS
   
   Unit tests added in `tests/unit_tests/common/test_query_context_processor.py`:
   
   - `test_processing_time_offsets_uses_chart_row_limit` — verifies the chart's `row_limit` is passed to offset subqueries when set
   - `test_processing_time_offsets_falls_back_to_config_row_limit` — verifies the config `ROW_LIMIT` is used when the chart has only `row_offset` and no `row_limit`
   
   Run with:
   ```
   pytest tests/unit_tests/common/test_query_context_processor.py::test_processing_time_offsets_uses_chart_row_limit tests/unit_tests/common/test_query_context_processor.py::test_processing_time_offsets_falls_back_to_config_row_limit -v
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4281718127

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39490?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.59%. Comparing base ([`8ce2343`](https://app.codecov.io/gh/apache/superset/commit/8ce234371b9c32d50a85eccaba4d46db9505e6e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`18508b6`](https://app.codecov.io/gh/apache/superset/commit/18508b6775d243649b166ae71fd606f998dfd70c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 22 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/39490?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/models/helpers.py](https://app.codecov.io/gh/apache/superset/pull/39490?src=pr&el=tree&filepath=superset%2Fmodels%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/39490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (8ce2343) and HEAD (18508b6). Click for more details.
   > 
   > <details><summary>HEAD has 64 uploads less than BASE</summary>
   >
   >| Flag | BASE (8ce2343) | HEAD (18508b6) |
   >|------|------|------|
   >|python|59|1|
   >|hive|7|1|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #39490      +/-   ##
   ==========================================
   - Coverage   64.51%   54.59%   -9.93%     
   ==========================================
     Files        2557     2557              
     Lines      133049   133116      +67     
     Branches    30901    30916      +15     
   ==========================================
   - Hits        85843    72681   -13162     
   - Misses      45716    60100   +14384     
   + Partials     1490      335    -1155     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.86% <0.00%> (-0.04%)` | :arrow_down: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.86% <0.00%> (-22.34%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/39490/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39490?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "JCelento (via GitHub)" <gi...@apache.org>.
JCelento commented on code in PR #39490:
URL: https://github.com/apache/superset/pull/39490#discussion_r3124305660


##########
superset/models/helpers.py:
##########
@@ -1589,7 +1589,9 @@ def processing_time_offsets(  # pylint: disable=too-many-locals,too-many-stateme
             # to the subquery so we prevent data inconsistency due to missing records
             # in the dataframes when performing the join
             if query_object.row_limit or query_object.row_offset:
-                query_object_clone_dct["row_limit"] = app.config["ROW_LIMIT"]
+                query_object_clone_dct["row_limit"] = (
+                    query_object.row_limit or app.config["ROW_LIMIT"]
+                )

Review Comment:
   Good catch. Fixed in a22629f. The subquery now uses `row_limit + row_offset` when the chart has a `row_limit` set, so the LEFT JOIN has coverage for dimensions across the full window and not just the first page. Added `test_processing_time_offsets_row_offset_extends_window` to lock in the new behavior, and updated the integration assertions from `LIMIT 100` to `LIMIT 110` for the `row_limit=100, row_offset=10` case. The `row_offset` only fallback still routes to `app.config["ROW_LIMIT"]`.



##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):
+    """Offset subquery inherits the chart's row_limit when one is set."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=100,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )

Review Comment:
   Right, `QueryObject.__init__` takes `filters=`; passing `filter=` was being swallowed by `**kwargs`. Fixed in a22629f in both new tests.



##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):
+    """Offset subquery inherits the chart's row_limit when one is set."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=100,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )
+
+    captured: list[dict[str, Any]] = []
+
+    def fake_query(dct: dict[str, Any]) -> MagicMock:
+        captured.append(dct)
+        result = MagicMock()
+        result.df = pd.DataFrame()
+        result.query = "SELECT 1"
+        return result
+
+    processor._qc_datasource.query = fake_query
+    processor._qc_datasource.normalize_df = MagicMock(return_value=pd.DataFrame())
+
+    with (
+        patch(
+            "superset.models.helpers.get_since_until_from_query_object",
+            return_value=(pd.Timestamp("1990-01-01"), pd.Timestamp("1991-01-01")),
+        ),
+        patch(
+            "superset.common.utils.query_cache_manager.QueryCacheManager"
+        ) as mock_cache_manager,
+        patch.object(
+            processor._qc_datasource,
+            "get_time_grain",
+            return_value=None,
+        ),
+        patch.object(
+            processor._qc_datasource,
+            "join_offset_dfs",
+            return_value=df,
+        ),
+    ):
+        mock_cache = MagicMock()
+        mock_cache.is_loaded = False
+        mock_cache_manager.get.return_value = mock_cache
+
+        processor._qc_datasource.processing_time_offsets(
+            df, query_object, None, None, False
+        )
+
+    assert len(captured) == 1
+    assert captured[0]["row_limit"] == 100
+    assert captured[0]["row_offset"] == 0
+
+
+def test_processing_time_offsets_falls_back_to_config_row_limit(processor):
+    """Offset subquery uses app config ROW_LIMIT when chart has offset but no limit."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=None,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )

Review Comment:
   Fixed in a22629f (same renaming `filter=` to `filters=` as the sibling test).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "JCelento (via GitHub)" <gi...@apache.org>.
JCelento commented on code in PR #39490:
URL: https://github.com/apache/superset/pull/39490#discussion_r3130404688


##########
tests/integration_tests/query_context_tests.py:
##########
@@ -794,28 +918,15 @@ def cache_timeout_fn():
 
     @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
     @patch("superset.common.query_context.QueryContext.get_query_result")
-    def test_time_offsets_in_query_object_no_limit(self, query_result_mock):
+    def test_time_offsets_in_query_object_uses_chart_row_limit(self, query_result_mock):
         """
-        Ensure that time_offsets can generate the correct queries and
-        it doesnt use the row_limit nor row_offset from the original

Review Comment:
   The subquery drops `row_offset` but honors `row_limit` (widened by `row_offset` so the join covers the main query's paginated window). Before this PR it fell back to `app.config["ROW_LIMIT"]` instead of the chart's `row_limit`, which is the inconsistency this PR fixes. Tightened the docstring in 2aefe9e to make that contrast explicit, let me know if it reads better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4360386444

   🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/25222847108) for [2aefe9e](https://github.com/apache/superset/commit/2aefe9e)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4281676349

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #39490:
URL: https://github.com/apache/superset/pull/39490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4281736637

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 18508b6775d243649b166ae71fd606f998dfd70c |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69e638a1ab058400070860f1 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-39490--superset-docs-preview.netlify.app](https://deploy-preview-39490--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTM5NDkwLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.xNK7NUoy_xxgunihmVHQLKjbVOUqN_1D7iVtKnMDNO8)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-39490--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "michaelmorera-preset (via GitHub)" <gi...@apache.org>.
michaelmorera-preset commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4360727615

   The application is working as expected.
   
   ## Testing Steps
   1. Create a new Table chart:
       1. **Dataset:** `birth_names`
       2. **Viz:** Table
       3. **Query mode:** Aggregate
       4. **Metrics:** `SUM(num)`
       5. **Dimensions:** `gender`
       6. **Filter on `ds`:** Custom range `2006-01-01` to `2008-01-01`
       7. **Row limit:** `10`
   2. Scroll to the **Time Comparison** section at the bottom of the Data tab:
       1. **Time shift:** `1 year ago`
   3. Click **Update chart** to run the query.
   4. Inspect the generated SQL — either open the chart's `⋯` → **View query** modal, or look at the `result[0].query` field in the `POST /api/v1/chart/data` response in DevTools Network.
   
   ## Current Result
   Both the main query and the Time Comparison query are respecting the chart-level row limit of 10.
   
   ## Evidence
   <img width="3360" height="744" alt="Table chart - Offset before and after" src="https://github.com/user-attachments/assets/a217f5bf-f91b-49e7-b2e2-aebf4b1b50f1" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "JCelento (via GitHub)" <gi...@apache.org>.
JCelento commented on code in PR #39490:
URL: https://github.com/apache/superset/pull/39490#discussion_r3124108076


##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):

Review Comment:
   Leaving this as is for consistency with the rest of the file. All of the existing test functions in `test_query_context_processor.py` use the `processor` fixture without annotations or a `-> None` return, and the sibling `test_processing_time_offsets_falls_back_to_config_row_limit` follows the same pattern. Happy to revisit if the file gets typed up as a whole.



##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):
+    """Offset subquery inherits the chart's row_limit when one is set."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=100,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )
+
+    captured: list[dict[str, Any]] = []
+
+    def fake_query(dct: dict[str, Any]) -> MagicMock:

Review Comment:
   Opted to skip the docstring here since `fake_query` is a small test-local closure that just captures the dict passed to `query()` so the assertions below can inspect it, and the surrounding test already has a docstring explaining the scenario. Open to adding one if it would help readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39490:
URL: https://github.com/apache/superset/pull/39490#discussion_r3124051517


##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):

Review Comment:
   **Suggestion:** Add explicit type hints for the `processor` parameter and the function return type to satisfy the typing requirement for new Python functions. [custom_rule]
   
   **Severity Level:** Minor ⚠️
   <details>
   <summary><b>Why it matters? 🤔 </b></summary>
   
   The new test function is missing type annotations on both the `processor` parameter and the return type. If the custom rule requires typing for newly added Python functions, this is a real violation in the current code.
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20703%3A703%0A%2A%2AComment%3A%2A%2A%0A%09%2ACustom%20Rule%3A%20Add%20explicit%20type%20hints%20for%20the%20%60processor%60%20parameter%20and%20the%20function%20return%20type%20to%20satisfy%20the%20typing%20requirement%20for%20new%20Python%20functions.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and
 %20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20703%3A703%0A%2A%2AComment%3A%2A%2A%0A%09%2ACustom%20Rule%3A%20Add%20explicit%20type%20hints%20for%20the%20%60processor%60%20parameter%20and%20the%20function%20return%20type%20to%20satisfy%20the%20typing%20requirement%20for%20new%20Python%20functions.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20
 the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** tests/unit_tests/common/test_query_context_processor.py
   **Line:** 703:703
   **Comment:**
   	*Custom Rule: Add explicit type hints for the `processor` parameter and the function return type to satisfy the typing requirement for new Python functions.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=17e84fbe4c7131a149e3cf34a2996cca0ce0ee5737db974e74284e0b7a70b530&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=17e84fbe4c7131a149e3cf34a2996cca0ce0ee5737db974e74284e0b7a70b530&reaction=dislike'>👎</a>



##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):
+    """Offset subquery inherits the chart's row_limit when one is set."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=100,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )
+
+    captured: list[dict[str, Any]] = []
+
+    def fake_query(dct: dict[str, Any]) -> MagicMock:

Review Comment:
   **Suggestion:** Add a docstring to this newly introduced helper function so all new function definitions include documentation. [custom_rule]
   
   **Severity Level:** Minor ⚠️
   <details>
   <summary><b>Why it matters? 🤔 </b></summary>
   
   The helper function is newly introduced and has no docstring. If the custom rule requires documentation for new function definitions, this is a real violation in the current code.
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20734%3A734%0A%2A%2AComment%3A%2A%2A%0A%09%2ACustom%20Rule%3A%20Add%20a%20docstring%20to%20this%20newly%20introduced%20helper%20function%20so%20all%20new%20function%20definitions%20include%20documentation.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in 
 VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20734%3A734%0A%2A%2AComment%3A%2A%2A%0A%09%2ACustom%20Rule%3A%20Add%20a%20docstring%20to%20this%20newly%20introduced%20helper%20function%20so%20all%20new%20function%20definitions%20include%20documentation.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** tests/unit_tests/common/test_query_context_processor.py
   **Line:** 734:734
   **Comment:**
   	*Custom Rule: Add a docstring to this newly introduced helper function so all new function definitions include documentation.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=66086e11e0695e1400d5a30889b895418bc86e6eaf4d8f42602b8858117648c6&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=66086e11e0695e1400d5a30889b895418bc86e6eaf4d8f42602b8858117648c6&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4297498609

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on code in PR #39490:
URL: https://github.com/apache/superset/pull/39490#discussion_r3125166174


##########
tests/integration_tests/query_context_tests.py:
##########
@@ -794,28 +918,15 @@ def cache_timeout_fn():
 
     @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
     @patch("superset.common.query_context.QueryContext.get_query_result")
-    def test_time_offsets_in_query_object_no_limit(self, query_result_mock):
+    def test_time_offsets_in_query_object_uses_chart_row_limit(self, query_result_mock):
         """
-        Ensure that time_offsets can generate the correct queries and
-        it doesnt use the row_limit nor row_offset from the original

Review Comment:
   This test implies the correct behaviour is to ignore row_limit and row_offset right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #39490:
URL: https://github.com/apache/superset/pull/39490#discussion_r3124089081


##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):
+    """Offset subquery inherits the chart's row_limit when one is set."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=100,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )

Review Comment:
   **Suggestion:** `QueryObject` expects `filters=...`, but this test passes `filter=...`, which is swallowed by `**kwargs` and never assigned to `query_object.filter`. As a result, the temporal filter is not actually present, so the test does not exercise the intended query path and can pass while filter-related behavior is broken. Use the correct `filters` argument name. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Time-offset row-limit test ignores configured temporal filter.
   - ⚠️ Filter-adjustment logic in processing_time_offsets untested here.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Run `pytest
   tests/unit_tests/common/test_query_context_processor.py::test_processing_time_offsets_uses_chart_row_limit`,
   which executes `test_processing_time_offsets_uses_chart_row_limit` defined at
   `tests/unit_tests/common/test_query_context_processor.py:703-125`. Inside this test, a
   `QueryObject` is instantiated at lines 714-730 with the keyword argument `filter=[{...}]`
   instead of `filters=[{...}]`.
   
   2. In `superset/common/query_object.py:34-59`, `QueryObject.__init__` defines a
   keyword-only parameter `filters` and collects unknown keywords in `**kwargs`. Because the
   test passes `filter=...`, `filters` remains `None` and `filter` is stored only in
   `kwargs`. At line 67, `self.filter = filters or []` executes, so `query_object.filter`
   becomes an empty list instead of the TEMPORAL_RANGE filter the test appears to intend.
   
   3. The test then calls `processor._qc_datasource.processing_time_offsets(df, query_object,
   None, None, False)` (lines 95-120), which is bound to
   `ExploreMixin.processing_time_offsets` implemented in
   `superset/models/helpers.py:1355-1613`. In that method, the relative-offset branches copy
   and mutate `query_object_clone.filter` when adjusting temporal filters (e.g. lines 118-125
   and 21-37 / 39-55), but in this test run `query_object_clone.filter` is empty because the
   constructor never received `filters=...`.
   
   4. The test asserts only on the `row_limit` and `row_offset` values passed into the fake
   `query` method (lines 83-124), and it patches `get_since_until_from_query_object` to
   return fixed datetimes (lines 95-99), so it never observes that `query_object.filter` is
   empty. As a result the misnamed `filter` argument is silently ignored, and this test does
   not exercise any behavior that depends on the presence or transformation of temporal
   filters.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20714%3A730%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20%60QueryObject%60%20expects%20%60filters%3D...%60%2C%20but%20this%20test%20passes%20%60filter%3D...%60%2C%20which%20is%20swallowed%20by%20%60%2A%2Akwargs%60%20and%20never%20assigned%20to%20%60query_object.filter%60.%20As%20a%20result%2C%20the%20temporal%20filter%20is%20not%20actually%20present%2C%20so%20the%20test%20does%20not%20exercise%20the%20intended%20query%20path%20and%20can%20pass%20while%20filter-related%20behavior%20is%20broken.%20Use%20the%20correct%20%60filters%60%20argument%20name.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%
 20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20714%3A730%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20%60QueryObject%60%20expects%20%60filters%3D...%60%2C%20but%20this%20test%20passes%20%60filter%3D...%60%2C%20which%20is%20swallowed%20by%20%60%2A%2Akwargs%60%20and%20never%20assigned%20to%20%60query_object.filter%60.%20As%20a%20result%2C%20the%20temporal%20filter%20is%20not%20actually%20present%2C%20so%20the%20test%20does%20not%
 20exercise%20the%20intended%20query%20path%20and%20can%20pass%20while%20filter-related%20behavior%20is%20broken.%20Use%20the%20correct%20%60filters%60%20argument%20name.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** tests/unit_tests/common/test_query_context_processor.py
   **Line:** 714:730
   **Comment:**
   	*Logic Error: `QueryObject` expects `filters=...`, but this test passes `filter=...`, which is swallowed by `**kwargs` and never assigned to `query_object.filter`. As a result, the temporal filter is not actually present, so the test does not exercise the intended query path and can pass while filter-related behavior is broken. Use the correct `filters` argument name.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=8dbb8c30edc3b9b869c23453cf681ad640fc605d94550e7e8bdc678927362618&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=8dbb8c30edc3b9b869c23453cf681ad640fc605d94550e7e8bdc678927362618&reaction=dislike'>👎</a>



##########
superset/models/helpers.py:
##########
@@ -1589,7 +1589,9 @@ def processing_time_offsets(  # pylint: disable=too-many-locals,too-many-stateme
             # to the subquery so we prevent data inconsistency due to missing records
             # in the dataframes when performing the join
             if query_object.row_limit or query_object.row_offset:
-                query_object_clone_dct["row_limit"] = app.config["ROW_LIMIT"]
+                query_object_clone_dct["row_limit"] = (
+                    query_object.row_limit or app.config["ROW_LIMIT"]
+                )

Review Comment:
   **Suggestion:** This limit calculation is incorrect when `row_offset` is non-zero: after resetting the offset subquery to `row_offset = 0`, keeping `row_limit` at the chart value fetches only the first page of rows instead of the shifted window used by the main query. That causes offset joins to miss matching rows (often producing null comparison values). Compute the subquery limit to cover the original window size (for example, include `row_offset` in the limit calculation) rather than using only `row_limit`. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ Time-comparison values null on paginated table charts.
   - ⚠️ Misleading analytics when using row_offset with time shifts.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Run a Superset instance with this PR code and load examples as described in the PR;
   this ensures `processing_time_offsets` in `superset/models/helpers.py:1579+` is used when
   time comparison is enabled for charts.
   
   2. In the UI, create or edit a **Table** chart on the `birth_names` dataset in aggregate
   mode (as in the PR description), then set `Row limit = 10` and `Row offset = 10` in the
   Data tab, and enable **Time Comparison** with `Time shift = 1 year ago`, then click
   **Update chart** to execute the query.
   
   3. The chart API request triggers query construction for the main query and its
   time-offset subqueries; for the offset subquery, `processing_time_offsets` in
   `superset/models/helpers.py:1579-1600` clones the original `query_object` and hits the
   block at lines `1591-1595` where `query_object.row_limit == 10` and
   `query_object.row_offset == 10`, so `query_object_clone_dct["row_limit"]` is set to `10`
   and `query_object_clone_dct["row_offset"]` is reset to `0`.
   
   4. Open the chart's **View query** modal and inspect the SQL: the main query will have
   `LIMIT 10 OFFSET 10` while the offset subquery (built via `processing_time_offsets`) will
   have `LIMIT 10 OFFSET 0`; when the result dataframes are joined on dimensions/time, some
   rows from the main query's window (positions 10–19) have no corresponding rows in the
   first 10 rows of the offset subquery, leading to null or missing comparison metrics for
   part of the paginated result set.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fmodels%2Fhelpers.py%0A%2A%2ALine%3A%2A%2A%201592%3A1594%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20This%20limit%20calculation%20is%20incorrect%20when%20%60row_offset%60%20is%20non-zero%3A%20after%20resetting%20the%20offset%20subquery%20to%20%60row_offset%20%3D%200%60%2C%20keeping%20%60row_limit%60%20at%20the%20chart%20value%20fetches%20only%20the%20first%20page%20of%20rows%20instead%20of%20the%20shifted%20window%20used%20by%20the%20main%20query.%20That%20causes%20offset%20joins%20to%20miss%20matching%20rows%20%28often%20producing%20null%20comparison%20values%29.%20Compute%20the%20subquery%20limit%20to%20cover%20the%20original%20window%20size%20%28for%20example%2C%20include%20%60row_offset%60%20in%20the%20limit%20calculation%29%20rather%20than%20using%20only%20%60row_limit%60.%0A%0AValidate%20the%20correctne
 ss%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20superset%2Fmodels%2Fhelpers.py%0A%2A%2ALine%3A%2A%2A%201592%3A1594%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20This%20limit%20calculation%20is%20incorrect%20when%20%60row_offset%60%20is%20non-zero%3A%20after%20resetting%20the%20offset%20subquery%20to%20%60row_offset%20%3D%200%60%2C%20keeping%20%60row_limit%6
 0%20at%20the%20chart%20value%20fetches%20only%20the%20first%20page%20of%20rows%20instead%20of%20the%20shifted%20window%20used%20by%20the%20main%20query.%20That%20causes%20offset%20joins%20to%20miss%20matching%20rows%20%28often%20producing%20null%20comparison%20values%29.%20Compute%20the%20subquery%20limit%20to%20cover%20the%20original%20window%20size%20%28for%20example%2C%20include%20%60row_offset%60%20in%20the%20limit%20calculation%29%20rather%20than%20using%20only%20%60row_limit%60.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20imp
 lement%20a%20minimal%20fix%0A)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/models/helpers.py
   **Line:** 1592:1594
   **Comment:**
   	*Logic Error: This limit calculation is incorrect when `row_offset` is non-zero: after resetting the offset subquery to `row_offset = 0`, keeping `row_limit` at the chart value fetches only the first page of rows instead of the shifted window used by the main query. That causes offset joins to miss matching rows (often producing null comparison values). Compute the subquery limit to cover the original window size (for example, include `row_offset` in the limit calculation) rather than using only `row_limit`.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=92ab06353338fe87e48032421c0029af59c00b02fc9a9beafef2a75237c8ae09&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=92ab06353338fe87e48032421c0029af59c00b02fc9a9beafef2a75237c8ae09&reaction=dislike'>👎</a>



##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -700,6 +700,154 @@ def test_processing_time_offsets_date_range_enabled(processor):
                             assert isinstance(result["cache_keys"], list)
 
 
+def test_processing_time_offsets_uses_chart_row_limit(processor):
+    """Offset subquery inherits the chart's row_limit when one is set."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=100,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )
+
+    captured: list[dict[str, Any]] = []
+
+    def fake_query(dct: dict[str, Any]) -> MagicMock:
+        captured.append(dct)
+        result = MagicMock()
+        result.df = pd.DataFrame()
+        result.query = "SELECT 1"
+        return result
+
+    processor._qc_datasource.query = fake_query
+    processor._qc_datasource.normalize_df = MagicMock(return_value=pd.DataFrame())
+
+    with (
+        patch(
+            "superset.models.helpers.get_since_until_from_query_object",
+            return_value=(pd.Timestamp("1990-01-01"), pd.Timestamp("1991-01-01")),
+        ),
+        patch(
+            "superset.common.utils.query_cache_manager.QueryCacheManager"
+        ) as mock_cache_manager,
+        patch.object(
+            processor._qc_datasource,
+            "get_time_grain",
+            return_value=None,
+        ),
+        patch.object(
+            processor._qc_datasource,
+            "join_offset_dfs",
+            return_value=df,
+        ),
+    ):
+        mock_cache = MagicMock()
+        mock_cache.is_loaded = False
+        mock_cache_manager.get.return_value = mock_cache
+
+        processor._qc_datasource.processing_time_offsets(
+            df, query_object, None, None, False
+        )
+
+    assert len(captured) == 1
+    assert captured[0]["row_limit"] == 100
+    assert captured[0]["row_offset"] == 0
+
+
+def test_processing_time_offsets_falls_back_to_config_row_limit(processor):
+    """Offset subquery uses app config ROW_LIMIT when chart has offset but no limit."""
+    from superset.common.query_object import QueryObject
+    from superset.models.helpers import ExploreMixin
+
+    processor._qc_datasource.processing_time_offsets = (
+        ExploreMixin.processing_time_offsets.__get__(processor._qc_datasource)
+    )
+
+    df = pd.DataFrame({"__timestamp": ["1990-01-01"], "sum__num": [100]})
+
+    query_object = QueryObject(
+        datasource=MagicMock(),
+        granularity="ds",
+        columns=[],
+        metrics=["sum__num"],
+        is_timeseries=True,
+        row_limit=None,
+        row_offset=10,
+        time_offsets=["1 year ago"],
+        filter=[
+            {
+                "col": "ds",
+                "op": "TEMPORAL_RANGE",
+                "val": "1990-01-01 : 1991-01-01",
+            }
+        ],
+    )

Review Comment:
   **Suggestion:** This test has the same constructor bug: it passes `filter=...` instead of `filters=...`, so the temporal filter is ignored by `QueryObject`. That makes the fallback-row-limit test less reliable because it is not running with the intended filter state. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Fallback-row-limit test also omits temporal filter coverage.
   - ⚠️ Potential regressions in filter handling may escape these tests.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Run `pytest
   tests/unit_tests/common/test_query_context_processor.py::test_processing_time_offsets_falls_back_to_config_row_limit`,
   which executes `test_processing_time_offsets_falls_back_to_config_row_limit` defined at
   `tests/unit_tests/common/test_query_context_processor.py:127-199`. Inside this test, a
   `QueryObject` is created at lines 787-803 with `filter=[{...}]` rather than
   `filters=[{...}]`.
   
   2. `QueryObject.__init__` in `superset/common/query_object.py:34-59` has a `filters`
   parameter and captures unknown keywords (including `filter`) in `**kwargs`. Because the
   test passes `filter=...`, the `filters` parameter stays `None`, and at line 67 the
   constructor sets `self.filter = filters or []`, so `query_object.filter` is an empty list,
   not the TEMPORAL_RANGE filter declared in the test.
   
   3. The test wires `processor._qc_datasource.processing_time_offsets` to
   `ExploreMixin.processing_time_offsets` and invokes it (lines 168-195). In
   `superset/models/helpers.py:1355-1613`, the method clones the query object and manipulates
   `query_object_clone.filter` when adjusting temporal filters for relative offsets (lines
   118-125 and 21-37 / 39-55), but because `query_object.filter` was empty, these branches
   operate on an empty filter list during this test.
   
   4. The test also patches `get_since_until_from_query_object` to return fixed bounds (lines
   169-172) and verifies only that the generated subquery dict has `row_limit == 4242` and
   `row_offset == 0` (lines 193-199). Thus the misuse of `filter` instead of `filters` means
   the temporal filter is never present on the `QueryObject`, and this test does not validate
   any behavior that depends on temporal filters while still passing.
   ```
   </details>
   
   [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20787%3A803%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20This%20test%20has%20the%20same%20constructor%20bug%3A%20it%20passes%20%60filter%3D...%60%20instead%20of%20%60filters%3D...%60%2C%20so%20the%20temporal%20filter%20is%20ignored%20by%20%60QueryObject%60.%20That%20makes%20the%20fallback-row-limit%20test%20less%20reliable%20because%20it%20is%20not%20running%20with%20the%20intended%20filter%20state.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wan
 ts%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20a%20comment%20left%20during%20a%20code%20review.%0A%0A%2A%2APath%3A%2A%2A%20tests%2Funit_tests%2Fcommon%2Ftest_query_context_processor.py%0A%2A%2ALine%3A%2A%2A%20787%3A803%0A%2A%2AComment%3A%2A%2A%0A%09%2ALogic%20Error%3A%20This%20test%20has%20the%20same%20constructor%20bug%3A%20it%20passes%20%60filter%3D...%60%20instead%20of%20%60filters%3D...%60%2C%20so%20the%20temporal%20filter%20is%20ignored%20by%20%60QueryObject%60.%20That%20makes%20the%20fallback-row-limit%20test%20less%20reliable%20because%20it%20is%20not%20running%20with%20the%20intended%20filter%20state.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propo
 se%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** tests/unit_tests/common/test_query_context_processor.py
   **Line:** 787:803
   **Comment:**
   	*Logic Error: This test has the same constructor bug: it passes `filter=...` instead of `filters=...`, so the temporal filter is ignored by `QueryObject`. That makes the fallback-row-limit test less reliable because it is not running with the intended filter state.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=2c1fd5001bd1bd07fb001cdb237954ac4a24ec1841ac50cc6a7067ec21523998&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39490&comment_hash=2c1fd5001bd1bd07fb001cdb237954ac4a24ec1841ac50cc6a7067ec21523998&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4296777099

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4304370986

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(time-comparison): use chart row_limit instead of instance config in offset queries [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39490:
URL: https://github.com/apache/superset/pull/39490#issuecomment-4360485610

   🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/25222847108) for [2aefe9e](https://github.com/apache/superset/commit/2aefe9e)
   
   • **Environment:** http://34.219.6.91:8080 (admin/admin)
   • **Lifetime:** 48h auto-cleanup
   • **Updates:** New commits create fresh environments automatically


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org