You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by kirklund <gi...@git.apache.org> on 2016/12/07 23:04:37 UTC

[GitHub] geode issue #297: GEODE-734: gfsh export stack-traces should not require an ...

Github user kirklund commented on the issue:

    https://github.com/apache/geode/pull/297
  
    I created feature/GEODE-734 branch and pulled in all changes. I also did a git rebase and combined all commits into a single commit:
    
    commit 2c5a0a1688b821f95584ef4b6610c65d0433d2e7
    Author: Deepak Dixit <de...@gmail.com>
    Date:   Sat Nov 26 19:11:52 2016 +0530
    
        GEODE-734: Remove txt file restriction when exporting stack traces
        
        Adding throws clause to signature instead of catching it in Test.
        
        Separating test scenarios into multiple test cases. Creating files in
        TemporaryFolder.
        
        Applying spotless checks
        
        Updated export stack-traces in controller. Removed compulsory file
        option. If file is not provided then name is generated. Added one
        boolean option fail-if-file-present, if true and file already exists
        then command will fail.
        
        Updated Offline help file.
        
        Added test cases to verify new added options
        
        Removed compulsory file option. If file is not provided then name is
        generated. Added one boolean option fail-if-file-present, if true and
        file already exists then command will fail.
        
        Added message warning user about possible overwrite of file if already
        present.
        
        Added test to check if non txt extension file is allowed.
        
        This closes #297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---