You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/07/11 11:09:36 UTC
[GitHub] [drill] jnturton opened a new pull request, #2590: DRILL-8158: Remove non-reproducible build outputs
jnturton opened a new pull request, #2590:
URL: https://github.com/apache/drill/pull/2590
# [DRILL-8158](https://issues.apache.org/jira/browse/DRILL-8158): Remove non-reproducible build outputs
## Description
For context see [1] and [2]. The git-commit-id plugin includes information like build host, email and time which is not compatible with a reproducible build. Drill's built in sys.version table will return the build email and time if they are present in the build's git.properties file so these columns must be deprecated. Other useful Git-related information is retained.
In accompanying commits, some Kerberos unit test fixes are applied, and the tests reenabled, and some updates to Release.md are included.
[1] https://maven.apache.org/guides/mini/guide-reproducible-builds.html
[2] https://github.com/jvm-repo-rebuild/reproducible-central#org.apache.drill:drill-root
## Documentation
Update the Query System Tables doc page.
## Testing
Run `select * from sys.version`. Manually inspect git.properties file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on a diff in pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on code in PR #2590:
URL: https://github.com/apache/drill/pull/2590#discussion_r919226171
##########
distribution/src/assemble/component.xml:
##########
@@ -245,10 +245,6 @@
<source>../NOTICE</source>
<outputDirectory />
</file>
- <file>
- <source>../git.properties</source>
Review Comment:
Let's leave this file to be placed in the target distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180731106
> [jnturton](https://github.com/jnturton) removed the[ backport-to-stable ](https://github.com/apache/drill/labels/backport-to-stable)label [6 hours ago](https://github.com/apache/drill/pull/2590#event-6968942212)
This PR is now not well structured. The reproducible build commits should not be backported while everything else should be. I'll split it into two in the morning, after seeing the results of this CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
jnturton merged PR #2590:
URL: https://github.com/apache/drill/pull/2590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1181306763
> This PR is now not well structured. The reproducible build commits should not be backported while everything else should be. I'll split it into two in the morning, after seeing the results of this CI run.
Okay, the Kerberos unit test fixes have been moved out to #2592.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on a diff in pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
jnturton commented on code in PR #2590:
URL: https://github.com/apache/drill/pull/2590#discussion_r919648732
##########
distribution/src/assemble/component.xml:
##########
@@ -245,10 +245,6 @@
<source>../NOTICE</source>
<outputDirectory />
</file>
- <file>
- <source>../git.properties</source>
Review Comment:
@vvysotskyi thanks that slipped through because I decided to start from the existing commit in the original PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180318047
Something I noticed when looking for git.properties after building is that it appeared in every jar files in jars/. It doesn't seem great for it to be heavily duplicated like this...
```
/opt/apache-drill/jars/drill-common-2.0.0-SNAPSHOT.jar
git.properties
/opt/apache-drill/jars/drill-druid-storage-2.0.0-SNAPSHOT.jar
git.properties
/opt/apache-drill/jars/drill-format-esri-2.0.0-SNAPSHOT.jar
git.properties
/opt/apache-drill/jars/drill-format-excel-2.0.0-SNAPSHOT.jar
git.properties
/opt/apache-drill/jars/drill-format-hdf5-2.0.0-SNAPSHOT.jar
git.properties
/opt/apache-drill/jars/drill-format-httpd-2.0.0-SNAPSHOT.jar
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180320689
Here I show the impact on the build_* columns in the sys.version table.
```
apache drill> select * from sys.version;
version 2.0.0-SNAPSHOT
commit_id 4bc34f0e317d160b98756ef5659bfc8c4c3b3d93
commit_message Limit the git-commit-id plugin properties for reproducible builds.
commit_time 11.07.2022 @ 12:25:56 SAST
build_email null
build_time null
1 row selected (1.768 seconds)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vvysotskyi commented on pull request #2590: DRILL-8158: Remove non-reproducible build outputs
Posted by GitBox <gi...@apache.org>.
vvysotskyi commented on PR #2590:
URL: https://github.com/apache/drill/pull/2590#issuecomment-1180417905
Properties file should be present in every Drill jar, it helps to find some issues, for example at one of the releases we had a bug when one of the Drill jars in the jars folder was outdated instead of the built from sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org