You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/31 08:52:09 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #10632:
[FLINK-15290][hive] Need a way to turn off vectorized orc reader for SQL CLI
JingsongLi commented on a change in pull request #10632: [FLINK-15290][hive] Need a way to turn off vectorized orc reader for SQL CLI
URL: https://github.com/apache/flink/pull/10632#discussion_r362173222
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/read/HiveTableInputFormat.java
##########
@@ -103,17 +105,16 @@ public HiveTableInputFormat(
this.jobConf = new JobConf(jobConf);
int rowArity = catalogTable.getSchema().getFieldCount();
selectedFields = projectedFields != null ? projectedFields : IntStream.range(0, rowArity).toArray();
+ useMapRedReader = GlobalConfiguration.loadConfiguration().getBoolean(HiveOptions.TABLE_EXEC_HIVE_FALLBACK_MAPRED_READER);
Review comment:
You can only pass `useMapRedReader` here.
We already have `GlobalConfiguration.loadConfiguration()` in `tableSource.getDataStream`. We can just get `useMapRedReader` and pass it to input format. It is good to reduce this unhappy codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services