You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/12 07:28:02 UTC

[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #2642: fix region/rack aware placement police replace bookie bug

hangc0276 commented on a change in pull request #2642:
URL: https://github.com/apache/bookkeeper/pull/2642#discussion_r592960595



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##########
@@ -456,7 +456,10 @@ public void uninitalize() {
             excludeBookies.addAll(currentEnsemble);
             BookieNode bn = knownBookies.get(bookieToReplace);
             if (null == bn) {
-                bn = createBookieNode(bookieToReplace);
+                bn = historyBookies.get(bookieToReplace);
+                if (null == bn) {
+                    bn = createBookieNode(bookieToReplace);

Review comment:
       Thanks for your quickly feedback. OK, it's better to fallback to history when resolve bookieId failed, it will update the code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org