You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/05/18 03:48:00 UTC
[jira] [Commented] (IMPALA-10699) Apply patch to libev to support compiling with C++17
[ https://issues.apache.org/jira/browse/IMPALA-10699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538558#comment-17538558 ]
ASF subversion and git services commented on IMPALA-10699:
----------------------------------------------------------
Commit 22272fb5d723b3d1b8a6e20a313c0f4be0129160 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=22272fb5d ]
IMPALA-10465, IMPALA-10699: Bump up native-toolchain
This patch bump up Impala native-toolchain. It includes:
- Increase IMPALA_KUDU_VERSION="09a6c8833e" (IMPALA-10465)
- Increase IMPALA_LIBEV_VERSION="4.20-p1" (IMPALA-10699).
Testing:
- Pass exhaustive tests.
Change-Id: I0b2d9b19fb9aeda9bc35829ce464aa2848b220ae
Reviewed-on: http://gerrit.cloudera.org:8080/18534
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Apply patch to libev to support compiling with C++17
> ----------------------------------------------------
>
> Key: IMPALA-10699
> URL: https://issues.apache.org/jira/browse/IMPALA-10699
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 4.0.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> When trying to compile with -std=c++17, multiple files fail to compile due to c++17 incompatible code in libev:
> {noformat}
> In file included from /home/joe/view2/Impala/be/src/kudu/rpc/connection.h:30:0,
> from /home/joe/view2/Impala/be/src/kudu/rpc/messenger.h:32,
> from /home/joe/view2/Impala/be/src/rpc/rpc-mgr.h:22,
> from /home/joe/view2/Impala/be/src/service/data-stream-service.cc:27:
> /opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/libev-4.20/include/ev++.h:355:46: error: ISO C++1z does not allow dynamic exception specifications
> dynamic_loop (unsigned int flags = AUTO) throw (bad_loop)
> ^~~~~
> {noformat}
> Kudu already applies a patch to libev's ev++.h to fix this, so we should apply the same patch to libev in native-toolchain.
> [https://github.com/apache/kudu/blob/master/thirdparty/patches/libev-c17.patch]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org