You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Gary-Hobson (via GitHub)" <gi...@apache.org> on 2024/09/18 13:00:06 UTC
[PR] sched: move DUMP_ON_EXIT to sched [nuttx]
Gary-Hobson opened a new pull request, #13525:
URL: https://github.com/apache/nuttx/pull/13525
## Summary
Change DUMP_ON_EXIT to CONFIG_SCHED_DUMP_ON_EXIT and move it to the sched directory
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched: move DUMP_ON_EXIT to sched [nuttx]
Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #13525:
URL: https://github.com/apache/nuttx/pull/13525#issuecomment-2358426584
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests)
## Does this PR meet the NuttX Requirements?
No, the PR is missing crucial information.
**Here's what's missing and needs to be added:**
**Summary:**
* **Why is this change necessary?** Is it a bug fix? Code cleanup? Improved organization?
* **What functional part of the code is changing?** Be specific. For example, "This changes the way the scheduler dumps its state on exit."
* **How does the change work?** Explain the mechanism behind the change. For example, "This change renames the `DUMP_ON_EXIT` configuration option to `CONFIG_SCHED_DUMP_ON_EXIT` and moves its definition to the `sched` directory to improve code organization and clarity."
**Impact:**
* Carefully consider and address **ALL** impact points. Even if the impact is "NO", state it explicitly (e.g., "Impact on build: NO").
* **For any "YES" impacts, provide details!**
**Testing:**
* **What build hosts did you test this on?** (OS, CPU architecture, compiler)
* **What target(s) did you test on?** (architecture, board, configuration)
* **Provide the actual testing logs** before and after the change to demonstrate the impact.
**Example of improved testing section:**
**Testing**
I confirm that changes are verified on the local setup and work as intended:
* Build Host(s):
* Ubuntu 22.04, x86_64, GCC 11.3.0
* Target(s):
* `sim:nsh` configuration
Testing logs before change:
```
<Insert logs from running your test case before the change>
```
Testing logs after change:
```
<Insert logs from running your test case after the change>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched: move DUMP_ON_EXIT to sched [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13525:
URL: https://github.com/apache/nuttx/pull/13525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org