You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/03/26 00:58:57 UTC
[kudu-CR] docs: Add a section for evolving gflags
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6489
Change subject: docs: Add a section for evolving gflags
......................................................................
docs: Add a section for evolving gflags
This patch adds a new section for evolving gflags in the documentation
and changes some of the XSLT logic to be more consistent.
It would be nice to replace the XSLT with a Python script.
Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
---
M docs/configuration_reference_unsupported.adoc
M docs/support/scripts/make_docs.sh
M docs/support/xsl/gflags_to_asciidoc.xsl
3 files changed, 58 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/6489/1
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: docs: Add a section for evolving gflags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6489/1/docs/configuration_reference_unsupported.adoc
File docs/configuration_reference_unsupported.adoc:
PS1, Line 30: The contents of this file are generated from the output of the `--helpxml`
: flag for each binary, during the build of the documentation. Do not edit this file
: or the included files manually.
> nit: Can this be commented out or somehow hidden? It appears, awkwardly, on
Ha, funny. Done.
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.
Change subject: docs: Add a section for evolving gflags
......................................................................
docs: Add a section for evolving gflags
This patch adds a new section for evolving gflags in the documentation
and changes some of the XSLT logic to be more consistent.
It would be nice to replace the XSLT with a Python script.
Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Reviewed-on: http://gerrit.cloudera.org:8080/6489
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M docs/configuration_reference.adoc
M docs/configuration_reference_unsupported.adoc
M docs/support/scripts/make_docs.sh
M docs/support/xsl/gflags_to_asciidoc.xsl
4 files changed, 64 insertions(+), 20 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: Add a section for evolving gflags
......................................................................
Patch Set 1: Code-Review+1
Seems reasonable. Do you have a published copy handy?
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6489
to look at the new patch set (#2).
Change subject: docs: Add a section for evolving gflags
......................................................................
docs: Add a section for evolving gflags
This patch adds a new section for evolving gflags in the documentation
and changes some of the XSLT logic to be more consistent.
It would be nice to replace the XSLT with a Python script.
Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
---
M docs/configuration_reference.adoc
M docs/configuration_reference_unsupported.adoc
M docs/support/scripts/make_docs.sh
M docs/support/xsl/gflags_to_asciidoc.xsl
4 files changed, 64 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/6489/2
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: docs: Add a section for evolving gflags
......................................................................
Patch Set 1:
Here you go: http://mpercy.github.io/kudu/docs/
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: docs: Add a section for evolving gflags
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] docs: Add a section for evolving gflags
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: docs: Add a section for evolving gflags
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Generated docs look good.
http://gerrit.cloudera.org:8080/#/c/6489/1/docs/configuration_reference_unsupported.adoc
File docs/configuration_reference_unsupported.adoc:
PS1, Line 30: The contents of this file are generated from the output of the `--helpxml`
: flag for each binary, during the build of the documentation. Do not edit this file
: or the included files manually.
nit: Can this be commented out or somehow hidden? It appears, awkwardly, on the website.
--
To view, visit http://gerrit.cloudera.org:8080/6489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I791d91e4f7ace4483958d26a60817857899fb474
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes