You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/12/29 08:35:54 UTC
[GitHub] [incubator-pekko] He-Pin opened a new pull request, #80: =sbt Make use of `File.separatorChar` to avoid exception.
He-Pin opened a new pull request, #80:
URL: https://github.com/apache/incubator-pekko/pull/80
Make use of `java.io.File.separatorChar` to work properly on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #80: =sbt Make use of `File.separatorChar` to avoid exception.
Posted by GitBox <gi...@apache.org>.
He-Pin commented on code in PR #80:
URL: https://github.com/apache/incubator-pekko/pull/80#discussion_r1058813812
##########
project/ValidatePullRequest.scala:
##########
@@ -46,7 +46,7 @@ object PekkoValidatePullRequest extends AutoPlugin {
loadedBuild.value.allProjectRefs.collect {
case (_, project) if !ignoredProjects.contains(project.id) =>
- val directory = project.base.getPath.split("/").last
+ val directory = project.base.getPath.split(java.io.File.separatorChar).last
Review Comment:
To help who is on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #80: =sbt Make use of `File.separatorChar` to avoid exception.
Posted by GitBox <gi...@apache.org>.
pjfanning merged PR #80:
URL: https://github.com/apache/incubator-pekko/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] sdeigm commented on pull request #80: =sbt Make use of `File.separatorChar` to avoid exception.
Posted by GitBox <gi...@apache.org>.
sdeigm commented on PR #80:
URL: https://github.com/apache/incubator-pekko/pull/80#issuecomment-1367569141
@pjfanning I tried this change and everything compiles without problems on Windows. I had a second look to my changes from a few days ago and I think they should be replaced by He-Pin's code since that code does the splitting that was originally intened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #80: =sbt Make use of `File.separatorChar` to avoid exception.
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #80:
URL: https://github.com/apache/incubator-pekko/pull/80#issuecomment-1367157963
@sdeigm could you try this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org