You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/22 01:41:43 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4838: Update schema API to reload table on schema change when
applicable
Jackie-Jiang commented on a change in pull request #4838: Update schema API to reload table on schema change when applicable
URL: https://github.com/apache/incubator-pinot/pull/4838#discussion_r349400690
##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -959,12 +961,35 @@ public PinotResourceManagerResponse deleteBrokerTenantFor(String tenantName) {
/**
* Schema APIs
*/
- public void addOrUpdateSchema(Schema schema) {
+ public void addOrUpdateSchema(Schema schema, boolean shouldAutoReload, boolean shouldOverride) {
Review comment:
I would recommend changing this to two method:
`addSchema(Schema schema, boolean override)`
`updateSchema(Schema schema, boolean reload)`
For `updateSchema`, throw exception when schema does not exist, or the change is not backward-compatible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org