[GitHub] [tvm] huajsj commented on a change in pull request #9751: [Runtime][Pipeline Executor] Add the map logic of global input and subgraph input.

[GitBox <gi...@apache.org>]

huajsj commented on a change in pull request #9751:
URL: https://github.com/apache/tvm/pull/9751#discussion_r770185406



##########
File path: src/runtime/pipeline/pipeline_struct.h
##########
@@ -71,44 +77,53 @@ struct OutputBindings {
       // When this output is bound to a global interface, check if the global interface index
       // start from 0.
       if (global_binding) {
-        ICHECK(global_output_index >= 0);
+        ICHECK(global_output_index_ >= 0);
       } else {
         // When this output is bound to a graph executor module interface, check if the module
         // index start from 0.
         ICHECK(mod_idx >= 0);
-        bindings[mod_idx] = input_name;
+        bindings_[mod_idx] = input_name;
       }
     }
   }
 };
-
 /*!
  * \brief The binding information of all outputs of a module.
  */
-struct OutputMap {
-  /*! \brief Output binding map, 'int' is output interface index.*/
-  std::unordered_map<int, OutputBindings> output_binding_map;
-  OutputMap& operator=(const OutputMap& output) {
-    output_binding_map = output.output_binding_map;
+class ConfigOutputBindings {
+ private:
+  /*!\brief The map of output binding, 'int' is the output interface index.*/
+  std::unordered_map<int, ConfigBindings> output_binding_map_;

Review comment:
       fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org