[jira] [Commented] (CB-12959) Conflict between camera and media capture plugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-12959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070157#comment-16070157 ] 

ASF GitHub Bot commented on CB-12959:
-------------------------------------

GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/274

    CB-12959: (android) Fix potential FileProvider conflicts

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Allows more than one plugin to use a FileProvider
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-camera CB12959

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #274
    
----
commit 94b6ba3d0687990c148f91ef83a33c53f8f8d4da
Author: Connor Pearson <cp...@b2wsoftware.com>
Date:   2017-06-30T13:59:27Z

    CB-12959: (android) Fix potential FileProvider conflicts

----


> Conflict between camera and media capture plugin
> ------------------------------------------------
>
>                 Key: CB-12959
>                 URL: https://issues.apache.org/jira/browse/CB-12959
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera, cordova-plugin-media-capture
>            Reporter: Connor Pearson
>            Priority: Minor
>
> We recently had a build fail the itunes upload due to NSCameraUsageDescription not being set. It was caused by the newer version of the media-capture plugin defining NSCameraUsageDescription and NSPhotoLibraryUsageDescriptionentry with an empty string and blowing away the value set by the camera plugin variables.
> The workaround is pretty simple: just set the same variables for both plugins, but I would expect core plugins to work nicely with each other. Is it necessary for the plugins to control these parameters? Could one define these values in config.xml instead of relying on the plugins?
> Also, if an empty string is no longer valid for app submission should it be added by default?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org