Re: [PR] GH-858: Fix error handling in CompositeJdbcConsumer [arrow-java]

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #857:
URL: https://github.com/apache/arrow-java/pull/857#discussion_r2377635420


##########
adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/CompositeJdbcConsumer.java:
##########
@@ -46,9 +45,9 @@ public void consume(ResultSet rs) throws SQLException, IOException {
           BaseConsumer consumer = (BaseConsumer) consumers[i];
           JdbcFieldInfo fieldInfo =
               new JdbcFieldInfo(rs.getMetaData(), consumer.columnIndexInResultSet);
-          ArrowType arrowType = consumer.vector.getMinorType().getType();
+
           throw new JdbcConsumerException(
-              "Exception while consuming JDBC value", e, fieldInfo, arrowType);
+              "Exception while consuming JDBC value", e, fieldInfo, consumer.vector.getMinorType());

Review Comment:
   Why not just `vector.getField()`? That'd be even better (you get the field name and type)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org