You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Kevin Menard (JIRA)" <de...@tapestry.apache.org> on 2007/11/24 20:12:43 UTC
[jira] Created: (TAPESTRY-1932) Extend PropertyModel to handle
annotation tasks.
Extend PropertyModel to handle annotation tasks.
------------------------------------------------
Key: TAPESTRY-1932
URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
Project: Tapestry
Issue Type: Improvement
Affects Versions: 5.0.6
Reporter: Kevin Menard
Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
model.add("some_text_property").addValidation("required")
Or:
model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1932) Extend PropertyModel to handle
annotation tasks.
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571784#action_12571784 ]
Howard M. Lewis Ship commented on TAPESTRY-1932:
------------------------------------------------
I've been of two minds on this, for instance, when I was working on adding support for @Width. It's a question of where logic should live (to avoid duplication). Ultimately, support for @Width maybe wasn't implemented the correct way and that logic should be inside AbstractTextField rather than inside BeanModelSourceImpl/PropertyModelImpl.
> Extend PropertyModel to handle annotation tasks.
> ------------------------------------------------
>
> Key: TAPESTRY-1932
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 5.0.6
> Reporter: Kevin Menard
>
> Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
> What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
> model.add("some_text_property").addValidation("required")
> Or:
> model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1932) Extend PropertyModel to handle
annotation tasks.
Posted by "Kevin Menard (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Menard updated TAPESTRY-1932:
-----------------------------------
Component/s: Framework
> Extend PropertyModel to handle annotation tasks.
> ------------------------------------------------
>
> Key: TAPESTRY-1932
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 5.0.6
> Reporter: Kevin Menard
>
> Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
> What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
> model.add("some_text_property").addValidation("required")
> Or:
> model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1932) Extend PropertyModel to allow access
to annotations associated with the property
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1932.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.11
> Extend PropertyModel to allow access to annotations associated with the property
> --------------------------------------------------------------------------------
>
> Key: TAPESTRY-1932
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 5.0.6
> Reporter: Kevin Menard
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.11
>
>
> Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
> What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
> model.add("some_text_property").addValidation("required")
> Or:
> model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1932) Extend PropertyModel to handle
annotation tasks.
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554081 ]
Howard M. Lewis Ship commented on TAPESTRY-1932:
------------------------------------------------
Most of the things you want to do, outside of validation, are already supported by BeanModel and PropertyModel.
> Extend PropertyModel to handle annotation tasks.
> ------------------------------------------------
>
> Key: TAPESTRY-1932
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 5.0.6
> Reporter: Kevin Menard
>
> Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
> What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
> model.add("some_text_property").addValidation("required")
> Or:
> model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-1932) Extend PropertyModel to handle
annotation tasks.
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAPESTRY-1932:
----------------------------------------------
Assignee: Howard M. Lewis Ship
> Extend PropertyModel to handle annotation tasks.
> ------------------------------------------------
>
> Key: TAPESTRY-1932
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 5.0.6
> Reporter: Kevin Menard
> Assignee: Howard M. Lewis Ship
>
> Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
> What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
> model.add("some_text_property").addValidation("required")
> Or:
> model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1932) Extend PropertyModel to allow
access to annotations associated with the property
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-1932:
-------------------------------------------
Summary: Extend PropertyModel to allow access to annotations associated with the property (was: Extend PropertyModel to handle annotation tasks.)
This really went into a different direction, where PropertyModel implements AnnotationProvider and logic related to annotations can move right into the components themselves, where appropriate. For example, got rid of the width() and getWidth() methods on PropertyModel, and put logic related to @Width into AbstractTextField.
> Extend PropertyModel to allow access to annotations associated with the property
> --------------------------------------------------------------------------------
>
> Key: TAPESTRY-1932
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1932
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 5.0.6
> Reporter: Kevin Menard
> Assignee: Howard M. Lewis Ship
>
> Oftentimes I have to work with beans that I do not have the source for. These beans come out of a library that is shared amongst other apps or out of a third party library. As such, annotating fields with the "Validate" annotation or the proposed "PropertyType" annotation (see TAPESTRY-1931) are not possible.
> What would be great is if the PropertyModel exposed these customizations via API additions. Then, during model customization, one could do something similar to the following:
> model.add("some_text_property").addValidation("required")
> Or:
> model.add("some_text_property").setType("longtext")
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org