[jira] [Work logged] (CAMEL-13341) camel-linkedin: If accessToken is set, other credentials should be unnecessary

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CAMEL-13341?focusedWorklogId=215423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215423 ]

ASF GitHub Bot logged work on CAMEL-13341:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/19 12:55
            Start Date: 19/Mar/19 12:55
    Worklog Time Spent: 10m 
      Work Description: JiriOndrusek commented on pull request #2830: [CAMEL-13341] camel-linkedin: If accessToken is set, other credential…
URL: https://github.com/apache/camel/pull/2830
 
 
   …s should be unnecessary
   
   Issue https://issues.apache.org/jira/browse/CAMEL-13341
   
   Added better validation and handling of accessToken. Now it is possible to use only accessToken to configure linkedin component and no username, password, client id or secret is needed anymore.
   On the other hand is not possible to define both accessToken and username, password,  ...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 215423)
            Time Spent: 10m
    Remaining Estimate: 0h

> camel-linkedin: If accessToken is set, other credentials should be unnecessary
> ------------------------------------------------------------------------------
>
>                 Key: CAMEL-13341
>                 URL: https://issues.apache.org/jira/browse/CAMEL-13341
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-linkedin
>    Affects Versions: 3.0.0
>            Reporter: Jiri Ondrusek
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If you run camel-linkedin quickstart, it is possible to fill accessToken into configuration and with it, all other authentication parameters (userName, userPassword, clientId, clientSecret) are ignored, but can not be empty.
> For example this configuration works:
> {code}<bean id="linkedinConfiguration" class="org.apache.camel.component.linkedin.LinkedInConfiguration">
> 	<property name="clientId" value="null"/>
> 	<property name="clientSecret" value="null"/>
> 	<property name="redirectUri" value="https://localhost"/>
> 	<property name="userName" value="null"/>
> 	<property name="userPassword" value="null"/>
> 	<property name="accessToken" value="very long but correct access token"/>
> </bean>{code}
> But following configuration should work too (because no real value is removed from the first one):
> {code}<bean id="linkedinConfiguration" class="org.apache.camel.component.linkedin.LinkedInConfiguration">
> 	<property name="redirectUri" value="https://localhost"/>
> 	<property name="accessToken" value="very long but correct access token"/>
> </bean>{code}
> It should be possible to improve component a little bit to allow empty authentication parameters in case of filled accessToken.
> (other possible solution is to forbid accessToken functionality, but it will change back-compatibility and possibly harm some users)
> But it should not  be allowed to have filled accessToken and also authentication credential, because it will be misleading (for example accessToken could be created for different user)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)