You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2015/03/22 05:35:11 UTC

[jira] [Updated] (MAPREDUCE-5190) Unnecessary condition test in RandomSampler

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated MAPREDUCE-5190:
-------------------------------
    Component/s:     (was: mrv1)
                 mrv2

> Unnecessary condition test in RandomSampler
> -------------------------------------------
>
>                 Key: MAPREDUCE-5190
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5190
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 2.6.0
>            Reporter: Jingguo Yao
>            Assignee: Jingguo Yao
>            Priority: Minor
>         Attachments: MAPREDUCE-5190.patch
>
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> In getSampe method, there is a condition test after "int ind = r.nextInt(numSamples);". The test is "(ind != numSamples)".
> This test is unneeded since nextInt(numSamples) will not return numSamples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)