[GitHub] [accumulo] ctubbsii edited a comment on issue #1257: Created SequenceLexicoder to resolve #1252 (2.0)

[GitBox <gi...@apache.org>]

ctubbsii edited a comment on issue #1257: Created SequenceLexicoder to resolve #1252 (2.0)
URL: https://github.com/apache/accumulo/pull/1257#issuecomment-512080646
 
 
   > Most of the heavy lifting is already being done by the `ByteUtils.concat` and `ByteUtils.split` methods, which are called by both implementations, effectively providing the common implementation. There isn't much else that is really shareable between the two classes...
   
   Okay, that's fair. If there's something we can think of later to deduplicate common code, it can be done later, as a follow-on.
   
   The main differences between your implementation and my proposed one is that yours adds an extra delimiter on the end (via the concat method), even in the case of an empty list, whereas my suggestion wouldn't add one when the list is empty. But, either way is probably fine.
   
   > ...the automated "standard" formatting did some truly horrifying things...
   
   Agreed. That kind of stuff has been bothering me a bit, too. I recently changed some of the formatting rules to support Java 11 and to wrap more aggressively in some cases, but the rules probably still need some more tweaking.
   
   Our formatting rules are based on the Eclipse JDT formatter, used by the formatter-maven-plugin, and the config is located at: https://github.com/apache/accumulo/blob/master/contrib/Eclipse-Accumulo-Codestyle.xml ; feel free to open a PR to change the config or discuss on the mailing list any proposals you might have to improve the formatting. Just keep in mind that it's more important that we converge on a ruleset that can be automatically enforced, even if it's slightly inferior aesthetically, so changes should be within the capabilities of the JDT formatter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services