You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2023/09/01 09:05:00 UTC
[jira] [Commented] (OAK-10266) ClientIpFilterTest fails for localhost
[ https://issues.apache.org/jira/browse/OAK-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761242#comment-17761242 ]
Julian Reschke commented on OAK-10266:
--------------------------------------
{noformat}
diff --git a/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/ClientIpFilterTest.java b/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/ClientIpFilterTest.java
index 44d1f2f9c8..83f2df75a2 100644
--- a/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/ClientIpFilterTest.java
+++ b/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/standby/server/ClientIpFilterTest.java
@@ -67,7 +67,9 @@ public class ClientIpFilterTest {
@Test
public void test() throws Exception {
- assertEquals(match, new ClientIpFilter(parseFilters()).isAllowed(createAddress()));
+ InetSocketAddress adr = createAddress();
+ assertEquals("unexpected match (" + match + ") for address '" + adr + "' and filters '" + addresses + "'", match,
+ new ClientIpFilter(parseFilters()).isAllowed(adr));
}
private String[] parseFilters() {
{noformat}
improves diagnostics:
{noformat}
[ERROR] Failures:
[ERROR] ClientIpFilterTest.test:71 unexpected match (true) for address '/127.0.0.1:8080' and filters '' expected:<true> but was:<false>
[ERROR] ClientIpFilterTest.test:71 unexpected match (true) for address '/127.0.0.1:8080' and filters 'localhost' expected:<true> but was:<false>
{noformat}
> ClientIpFilterTest fails for localhost
> --------------------------------------
>
> Key: OAK-10266
> URL: https://issues.apache.org/jira/browse/OAK-10266
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
> Reporter: Marcel Reutegger
> Priority: Minor
>
> ClientIpFilterTest fails on my machine for filters=localhost.
> The JVM returns an IP v6 address, which does not match the expected 127.0.0.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)