You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/06/22 09:01:41 UTC
[GitHub] [incubator-mxnet] anko-intel opened a new pull request, #21079: Fix DNNL requantize operator overflow error
anko-intel opened a new pull request, #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079
## Description ##
It fixes overflow issue which sometimes happenes giving negative scales.
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
## Note ##
Simple way to reproduce the bug:
MXNET_TEST_SEED=970044477 pytest tests/python/dnnl/subgraphs/test_fc_subgraph.py::test_add_quantized[ele_add-no_broadc-nore-full-none-int8]
but with modyfied shape to
` data_shape = (4,6)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
anko-intel commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1163523126
@mxnet-bot run ci [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21079: Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1162841093
Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, unix-cpu, sanity, centos-cpu, unix-gpu, windows-gpu, clang, miscellaneous, website, edge, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
anko-intel commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1165547012
@mxnet-bot run ci [centos-gpu, unix-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1165547293
Jenkins CI successfully triggered : [unix-cpu, centos-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
anko-intel commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1165237159
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1163523230
Jenkins CI successfully triggered : [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1165869568
Jenkins CI successfully triggered : [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1165237231
Jenkins CI successfully triggered : [unix-gpu, unix-cpu, centos-gpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1163281927
Jenkins CI successfully triggered : [windows-gpu, edge, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
anko-intel commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1163281746
@mxnet-bot run ci [edge, website,windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
bgawrych merged PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
anko-intel commented on PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#issuecomment-1165869437
@mxnet-bot run ci [centos-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on code in PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#discussion_r904822769
##########
src/operator/quantization/dnnl/dnnl_requantize-inl.h:
##########
@@ -132,7 +132,8 @@ static void DNNLRequantizeForward(const nnvm::NodeAttrs& attrs,
data_min = data_mins[i];
}
float src_range = MinAbs(MinValue<SrcDType>(), MaxValue<SrcDType>());
- SrcDType data_range = MaxAbs(data_min, data_max);
+ // It doesn't use MaxAbs as it convert data to float which could cause overflow errors
Review Comment:
```suggestion
// MaxAbs is not used here as it converts data to float what could cause overflow errors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a diff in pull request #21079: [BUGFIX] Fix DNNL requantize operator overflow error
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on code in PR #21079:
URL: https://github.com/apache/incubator-mxnet/pull/21079#discussion_r904822769
##########
src/operator/quantization/dnnl/dnnl_requantize-inl.h:
##########
@@ -132,7 +132,8 @@ static void DNNLRequantizeForward(const nnvm::NodeAttrs& attrs,
data_min = data_mins[i];
}
float src_range = MinAbs(MinValue<SrcDType>(), MaxValue<SrcDType>());
- SrcDType data_range = MaxAbs(data_min, data_max);
+ // It doesn't use MaxAbs as it convert data to float which could cause overflow errors
Review Comment:
```suggestion
// MaxAbs is not used here as it converts data to float which could cause overflow errors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org