You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by ri...@gmail.com on 2009/03/01 10:23:26 UTC
Re: svn commit: r748683 - in /ofbiz/trunk/applications: content/entitydef/entitymodel.xml order/entitydef/entitymodel.xml party/entitydef/entitymodel.xml
I have seen that some contentId are inserted into "seed" xml file and
some into "demo" xml file and so it can cause some little confusion.
For example ContentTypeData.xml, MiscData.xml, SeedBlogData.xml,
Template.xml having some contentId but those file are declared as seed
data.
I have removed "default-resource-name" attribute from Content and
PartyClassificationGroup entity definition into rev. 748987.
I will remove it from Content entity labels on the next days if no-one
disagree with this.
Thanks
Marco
Il giorno 28/feb/09, alle ore 22:53, David E Jones ha scritto:
>
> Wow, these are worse than I thought. I'm not sure where these came
> from, or what the point of them is, but yes there certainly are a
> number of Content.contentName and Content.description entries.
>
> One thing to keep in mind about those fields is they are usually for
> internal use ONLY, so i18n isn't needed. We don't need to
> internationalize EVERY field in the database... why not? Because
> that would imply that every field, even those used for internal
> administration by a smaller group of people who speak the same
> language, would need to be translated. Also, if an organization
> allowed entry in any language desired it would make it tough for
> those who didn't understand that language but needed to work with
> the data. In other words, it's a huge can of worms from a business/
> organization/process perspective, and not something that technology
> can fix. There are specific places where i18n is needed and wanted.
>
> Also, these values are in demo data and so the information in this
> file isn't even used or helpful for many instances of OFBiz.
>
> My vote would be to remove those labels and also remove that setting
> from the Content entity. I don't think there is any reason to
> translate them as they would be used internally only and are of a
> somewhat technical nature for these demo Content records, kind of
> like comments in code.
>
> -David
>
>
> On Feb 27, 2009, at 2:46 PM, risalitim@gmail.com wrote:
>
>> Hi David,
>>
>> I agree with you but there are a lot of Content.description
>> translation and PartyClassification.description labels and in this
>> case we need to remove it or use it (adding default-resource-name
>> on the entity).
>> Anyway I can revert the default-resource-name for those specific
>> entities or remove those labels.
>> What did you think of it ?
>>
>> Thanks
>> Marco
>>
>> Il giorno 27/feb/09, alle ore 22:29, David E Jones ha scritto:
>>
>>>
>>> Are the entity field labels actually used for all of these entities?
>>>
>>> Generally this feature ONLY makes sense for things that are part
>>> of seed data, things that may be entered by users should use other
>>> patterns for i18n.
>>>
>>> The suspect entities that are included here include:
>>>
>>> - Content (has the alternate locale associated content pattern for
>>> i18n)
>>> - PartyClassificationGroup
>>>
>>> The rest look fine, and are populated by seed data (ie data that
>>> is maintained with code).
>>>
>>> -David
>>>
>>>
>>> On Feb 27, 2009, at 1:26 PM, mrisaliti@apache.org wrote:
>>>
>>>> Author: mrisaliti
>>>> Date: Fri Feb 27 20:26:54 2009
>>>> New Revision: 748683
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=748683&view=rev
>>>> Log:
>>>> Some missing default-resource-name for entity labels.
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/content/entitydef/entitymodel.xml
>>>> ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>>>> ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>>>>
>>>> Modified: ofbiz/trunk/applications/content/entitydef/
>>>> entitymodel.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>> --- ofbiz/trunk/applications/content/entitydef/entitymodel.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/content/entitydef/entitymodel.xml
>>>> Fri Feb 27 20:26:54 2009
>>>> @@ -150,6 +150,7 @@
>>>>
>>>> <entity entity-name="Content"
>>>> package-name="org.ofbiz.content.content"
>>>> + default-resource-name="ContentEntityLabels"
>>>> title="Content Entity">
>>>> <field name="contentId" type="id-ne"></field>
>>>> <field name="contentTypeId" type="id"></field>
>>>> @@ -412,6 +413,7 @@
>>>> </view-entity>
>>>> <entity entity-name="ContentAssocPredicate"
>>>> package-name="org.ofbiz.content.content"
>>>> + default-resource-name="ContentEntityLabels"
>>>> title="Content Association Predicate Entity">
>>>> <field name="contentAssocPredicateId" type="id-ne"></field>
>>>> <field name="description" type="description"></field>
>>>> @@ -731,6 +733,7 @@
>>>> </entity>
>>>> <entity entity-name="CharacterSet"
>>>> package-name="org.ofbiz.content.data"
>>>> + default-resource-name="ContentEntityLabels"
>>>> title="Character Set Entity">
>>>> <field name="characterSetId" type="id-long-ne"></field>
>>>> <field name="description" type="description"></field>
>>>> @@ -1093,6 +1096,7 @@
>>>> </entity>
>>>> <entity entity-name="DocumentType"
>>>> package-name="org.ofbiz.content.document"
>>>> + default-resource-name="ContentEntityLabels"
>>>> title="Document Type Entity">
>>>> <field name="documentTypeId" type="id-ne"></field>
>>>> <field name="parentTypeId" type="id-ne"></field>
>>>>
>>>> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>> --- ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/order/entitydef/entitymodel.xml Fri
>>>> Feb 27 20:26:54 2009
>>>> @@ -253,6 +253,7 @@
>>>> </entity>
>>>> <entity entity-name="OrderBlacklistType"
>>>> package-name="org.ofbiz.order.order"
>>>> + default-resource-name="OrderEntityLabels"
>>>> title="Order Blacklist Type Entity">
>>>> <field name="orderBlacklistTypeId" type="id-ne"></field>
>>>> <field name="description" type="description"></field>
>>>> @@ -912,6 +913,7 @@
>>>> </entity>
>>>> <entity entity-name="OrderItemType"
>>>> package-name="org.ofbiz.order.order"
>>>> + default-resource-name="OrderEntityLabels"
>>>> title="Order Item Type Entity">
>>>> <field name="orderItemTypeId" type="id-ne"></field>
>>>> <field name="parentTypeId" type="id-ne"></field>
>>>> @@ -1276,6 +1278,7 @@
>>>> </entity>
>>>> <entity entity-name="OrderContentType"
>>>> package-name="org.ofbiz.order.order"
>>>> + default-resource-name="OrderEntityLabels"
>>>> title="Order Content Type Entity">
>>>> <field name="orderContentTypeId" type="id-ne"></field>
>>>> <field name="parentTypeId" type="id"></field>
>>>>
>>>> Modified: ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>> --- ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/party/entitydef/entitymodel.xml Fri
>>>> Feb 27 20:26:54 2009
>>>> @@ -1800,6 +1800,7 @@
>>>> </entity>
>>>> <entity entity-name="PartyClassificationGroup"
>>>> package-name="org.ofbiz.party.party"
>>>> + default-resource-name="PartyEntityLabels"
>>>> title="Party Classification Group Entity">
>>>> <field name="partyClassificationGroupId" type="id-ne"></field>
>>>> <field name="partyClassificationTypeId" type="id"></field>
>>>>
>>>>
>>>
>>
>
Re: svn commit: r748683 - in /ofbiz/trunk/applications: content/entitydef/entitymodel.xml order/entitydef/entitymodel.xml party/entitydef/entitymodel.xml
Posted by ri...@gmail.com,
ri...@gmail.com.
I have removed Content.name e Content.description from
ContentEntityLabels.xml into rev. 751219.
Thanks
Marco
Il giorno 01/mar/09, alle ore 10:23, risalitim@gmail.com ha scritto:
> I have seen that some contentId are inserted into "seed" xml file
> and some into "demo" xml file and so it can cause some little
> confusion.
> For example ContentTypeData.xml, MiscData.xml, SeedBlogData.xml,
> Template.xml having some contentId but those file are declared as
> seed data.
>
> I have removed "default-resource-name" attribute from Content and
> PartyClassificationGroup entity definition into rev. 748987.
>
> I will remove it from Content entity labels on the next days if no-
> one disagree with this.
>
> Thanks
> Marco
>
>
> Il giorno 28/feb/09, alle ore 22:53, David E Jones ha scritto:
>
>>
>> Wow, these are worse than I thought. I'm not sure where these came
>> from, or what the point of them is, but yes there certainly are a
>> number of Content.contentName and Content.description entries.
>>
>> One thing to keep in mind about those fields is they are usually
>> for internal use ONLY, so i18n isn't needed. We don't need to
>> internationalize EVERY field in the database... why not? Because
>> that would imply that every field, even those used for internal
>> administration by a smaller group of people who speak the same
>> language, would need to be translated. Also, if an organization
>> allowed entry in any language desired it would make it tough for
>> those who didn't understand that language but needed to work with
>> the data. In other words, it's a huge can of worms from a business/
>> organization/process perspective, and not something that technology
>> can fix. There are specific places where i18n is needed and wanted.
>>
>> Also, these values are in demo data and so the information in this
>> file isn't even used or helpful for many instances of OFBiz.
>>
>> My vote would be to remove those labels and also remove that
>> setting from the Content entity. I don't think there is any reason
>> to translate them as they would be used internally only and are of
>> a somewhat technical nature for these demo Content records, kind of
>> like comments in code.
>>
>> -David
>>
>>
>> On Feb 27, 2009, at 2:46 PM, risalitim@gmail.com wrote:
>>
>>> Hi David,
>>>
>>> I agree with you but there are a lot of Content.description
>>> translation and PartyClassification.description labels and in this
>>> case we need to remove it or use it (adding default-resource-name
>>> on the entity).
>>> Anyway I can revert the default-resource-name for those specific
>>> entities or remove those labels.
>>> What did you think of it ?
>>>
>>> Thanks
>>> Marco
>>>
>>> Il giorno 27/feb/09, alle ore 22:29, David E Jones ha scritto:
>>>
>>>>
>>>> Are the entity field labels actually used for all of these
>>>> entities?
>>>>
>>>> Generally this feature ONLY makes sense for things that are part
>>>> of seed data, things that may be entered by users should use
>>>> other patterns for i18n.
>>>>
>>>> The suspect entities that are included here include:
>>>>
>>>> - Content (has the alternate locale associated content pattern
>>>> for i18n)
>>>> - PartyClassificationGroup
>>>>
>>>> The rest look fine, and are populated by seed data (ie data that
>>>> is maintained with code).
>>>>
>>>> -David
>>>>
>>>>
>>>> On Feb 27, 2009, at 1:26 PM, mrisaliti@apache.org wrote:
>>>>
>>>>> Author: mrisaliti
>>>>> Date: Fri Feb 27 20:26:54 2009
>>>>> New Revision: 748683
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=748683&view=rev
>>>>> Log:
>>>>> Some missing default-resource-name for entity labels.
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/content/entitydef/entitymodel.xml
>>>>> ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>>>>> ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>>>>>
>>>>> Modified: ofbiz/trunk/applications/content/entitydef/
>>>>> entitymodel.xml
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> ==================================================================
>>>>> --- ofbiz/trunk/applications/content/entitydef/entitymodel.xml
>>>>> (original)
>>>>> +++ ofbiz/trunk/applications/content/entitydef/entitymodel.xml
>>>>> Fri Feb 27 20:26:54 2009
>>>>> @@ -150,6 +150,7 @@
>>>>>
>>>>> <entity entity-name="Content"
>>>>> package-name="org.ofbiz.content.content"
>>>>> + default-resource-name="ContentEntityLabels"
>>>>> title="Content Entity">
>>>>> <field name="contentId" type="id-ne"></field>
>>>>> <field name="contentTypeId" type="id"></field>
>>>>> @@ -412,6 +413,7 @@
>>>>> </view-entity>
>>>>> <entity entity-name="ContentAssocPredicate"
>>>>> package-name="org.ofbiz.content.content"
>>>>> + default-resource-name="ContentEntityLabels"
>>>>> title="Content Association Predicate Entity">
>>>>> <field name="contentAssocPredicateId" type="id-ne"></field>
>>>>> <field name="description" type="description"></field>
>>>>> @@ -731,6 +733,7 @@
>>>>> </entity>
>>>>> <entity entity-name="CharacterSet"
>>>>> package-name="org.ofbiz.content.data"
>>>>> + default-resource-name="ContentEntityLabels"
>>>>> title="Character Set Entity">
>>>>> <field name="characterSetId" type="id-long-ne"></field>
>>>>> <field name="description" type="description"></field>
>>>>> @@ -1093,6 +1096,7 @@
>>>>> </entity>
>>>>> <entity entity-name="DocumentType"
>>>>> package-name="org.ofbiz.content.document"
>>>>> + default-resource-name="ContentEntityLabels"
>>>>> title="Document Type Entity">
>>>>> <field name="documentTypeId" type="id-ne"></field>
>>>>> <field name="parentTypeId" type="id-ne"></field>
>>>>>
>>>>> Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> ==================================================================
>>>>> --- ofbiz/trunk/applications/order/entitydef/entitymodel.xml
>>>>> (original)
>>>>> +++ ofbiz/trunk/applications/order/entitydef/entitymodel.xml Fri
>>>>> Feb 27 20:26:54 2009
>>>>> @@ -253,6 +253,7 @@
>>>>> </entity>
>>>>> <entity entity-name="OrderBlacklistType"
>>>>> package-name="org.ofbiz.order.order"
>>>>> + default-resource-name="OrderEntityLabels"
>>>>> title="Order Blacklist Type Entity">
>>>>> <field name="orderBlacklistTypeId" type="id-ne"></field>
>>>>> <field name="description" type="description"></field>
>>>>> @@ -912,6 +913,7 @@
>>>>> </entity>
>>>>> <entity entity-name="OrderItemType"
>>>>> package-name="org.ofbiz.order.order"
>>>>> + default-resource-name="OrderEntityLabels"
>>>>> title="Order Item Type Entity">
>>>>> <field name="orderItemTypeId" type="id-ne"></field>
>>>>> <field name="parentTypeId" type="id-ne"></field>
>>>>> @@ -1276,6 +1278,7 @@
>>>>> </entity>
>>>>> <entity entity-name="OrderContentType"
>>>>> package-name="org.ofbiz.order.order"
>>>>> + default-resource-name="OrderEntityLabels"
>>>>> title="Order Content Type Entity">
>>>>> <field name="orderContentTypeId" type="id-ne"></field>
>>>>> <field name="parentTypeId" type="id"></field>
>>>>>
>>>>> Modified: ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/entitydef/entitymodel.xml?rev=748683&r1=748682&r2=748683&view=diff
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> =
>>>>> ==================================================================
>>>>> --- ofbiz/trunk/applications/party/entitydef/entitymodel.xml
>>>>> (original)
>>>>> +++ ofbiz/trunk/applications/party/entitydef/entitymodel.xml Fri
>>>>> Feb 27 20:26:54 2009
>>>>> @@ -1800,6 +1800,7 @@
>>>>> </entity>
>>>>> <entity entity-name="PartyClassificationGroup"
>>>>> package-name="org.ofbiz.party.party"
>>>>> + default-resource-name="PartyEntityLabels"
>>>>> title="Party Classification Group Entity">
>>>>> <field name="partyClassificationGroupId" type="id-ne"></field>
>>>>> <field name="partyClassificationTypeId" type="id"></field>
>>>>>
>>>>>
>>>>
>>>
>>
>