[GitHub] [kafka] stanislavkozlovski commented on pull request #9371: KAFKA-10510: Validate replication factor consistency on reassignment

[GitBox <gi...@apache.org>]

stanislavkozlovski commented on pull request #9371:
URL: https://github.com/apache/kafka/pull/9371#issuecomment-704300915


   Thanks for the PR @piotrrzysko. The changes look good although I'm not sure if we're not regressing the ability to change the replication factor of a topic if we're to outright block it.
   
   Perhaps we could have a workaround in the form of allowing the reassignment batch to run if it's changing all the partitions for the topic. Another solution I like more is adding a flag to the AlterPartitionReassignments API that allows it to change the replication factor and keeping this validation.
   
   In the long term, I think we may want to consider an API that allows you to alter the replication factor of a topic.
   
   cc @ijuma @gwenshap @cmccabe @hachikuji @soondenana do you happen to have any thoughts on the matter?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org