[GitHub] [phoenix] swaroopak commented on a change in pull request #746: PHOENIX-5802: Connection leaks in UPSERT SELECT/DELETE paths due to MutatingParallelIteratorFactory iterator not being closed

[GitBox <gi...@apache.org>]

swaroopak commented on a change in pull request #746: PHOENIX-5802: Connection leaks in UPSERT SELECT/DELETE paths due to MutatingParallelIteratorFactory iterator not being closed
URL: https://github.com/apache/phoenix/pull/746#discussion_r399413744
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectIT.java
 ##########
 @@ -1242,11 +1384,13 @@ public void testRowTimestampColWithViewsIndexesAndSaltedTables() throws Exceptio
             tenantConn.commit();
         }
 
-        // Verify that the data upserted using the tenant view can now be queried using base table and the base table index
+        // Verify that the data upserted using the tenant view can now be queried using base table
+        // and the base table index
         Date upsertedDate;
         try (Connection conn = DriverManager.getConnection(getUrl(), props)) {
             // Query the base table
-            PreparedStatement stmt = conn.prepareStatement("SELECT * FROM  " + baseTable + " WHERE TENANT_ID = ? AND PK2 >= ? AND PK2 <= ? AND PK3 = ? ");
+            PreparedStatement stmt = conn.prepareStatement("SELECT * FROM  " + baseTable +
 
 Review comment:
   why not use try-with-resources for statement also?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services