You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2018/08/03 13:23:48 UTC

[GitHub] storm pull request #2752: Storm 1311 Migration of UI from clj to Java

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2752#discussion_r207542398
  
    --- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java ---
    @@ -137,7 +137,7 @@ public Response searchLogs(@Context HttpServletRequest request) throws IOExcepti
             String user = httpCredsHandler.getUserName(request);
             String topologyId = request.getParameter("topoId");
             String portStr = request.getParameter("port");
    -        String callback = request.getParameter("callback");
    +        String callback = request.getParameter("callbackParameterName");
    --- End diff --
    
    So why are we changing `/searchLogs?callback=bar` to `/searchLogs?callbackParameterName=bar`?  If that is what we are doing it is a regression, if not I am really missing something.


---