You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by Matthias Friedrich <ma...@mafr.de> on 2012/10/13 15:11:39 UTC
Code Reviews
Hi,
Apache runs a ReviewBoard instance [1]. I don't have a lot of
experience with review software, but I think it would help us
streamline our process. I expect reviewing large patches and
suggesting changes would work much better on ReviewBoard than
on JIRA.
I'd suggest that patches should still be attached to a JIRA issue
(it's necessary for legal reasons anyway), but larger ones can
additionally be posted to ReviewBoard.
It looks like everybody can create accounts at ReviewBoard but
INFRA needs to set up a group for Crunch. I'd make a ticket if
we decide to give it a try.
Regards,
Matthias
[1] https://reviews.apache.org
Re: Code Reviews
Posted by Gabriel Reid <ga...@gmail.com>.
Thanks for the follow-up on that Matthias.
I've just posted the patch for CRUNCH-102 on RB, and assigned it to myself, Matthias, and Rahul for review (I couldn't find Josh in the user list), and it appears to have worked.
- Gabriel
On 27 Oct 2012, at 09:19, Matthias Friedrich <ma...@mafr.de> wrote:
> Hi,
>
> according to INFRA, RB should now work for us. Apparently there was
> some issue fetching our git repo.
>
> Regards,
> Matthias
>
> On Friday, 2012-10-19, Matthias Friedrich wrote:
>> Hi,
>>
>> we now have a ReviewBoard group for Crunch, with notifications going
>> to crunch-dev.
>>
>> Regards,
>> Matthias
>>
>> On Saturday, 2012-10-13, Matthias Friedrich wrote:
>>> Hi,
>>>
>>> Apache runs a ReviewBoard instance [1]. I don't have a lot of
>>> experience with review software, but I think it would help us
>>> streamline our process. I expect reviewing large patches and
>>> suggesting changes would work much better on ReviewBoard than
>>> on JIRA.
>>>
>>> I'd suggest that patches should still be attached to a JIRA issue
>>> (it's necessary for legal reasons anyway), but larger ones can
>>> additionally be posted to ReviewBoard.
>>>
>>> It looks like everybody can create accounts at ReviewBoard but
>>> INFRA needs to set up a group for Crunch. I'd make a ticket if
>>> we decide to give it a try.
>>>
>>> Regards,
>>> Matthias
>>>
>>> [1] https://reviews.apache.org
Re: Code Reviews
Posted by Matthias Friedrich <ma...@mafr.de>.
Hi,
according to INFRA, RB should now work for us. Apparently there was
some issue fetching our git repo.
Regards,
Matthias
On Friday, 2012-10-19, Matthias Friedrich wrote:
> Hi,
>
> we now have a ReviewBoard group for Crunch, with notifications going
> to crunch-dev.
>
> Regards,
> Matthias
>
> On Saturday, 2012-10-13, Matthias Friedrich wrote:
> > Hi,
> >
> > Apache runs a ReviewBoard instance [1]. I don't have a lot of
> > experience with review software, but I think it would help us
> > streamline our process. I expect reviewing large patches and
> > suggesting changes would work much better on ReviewBoard than
> > on JIRA.
> >
> > I'd suggest that patches should still be attached to a JIRA issue
> > (it's necessary for legal reasons anyway), but larger ones can
> > additionally be posted to ReviewBoard.
> >
> > It looks like everybody can create accounts at ReviewBoard but
> > INFRA needs to set up a group for Crunch. I'd make a ticket if
> > we decide to give it a try.
> >
> > Regards,
> > Matthias
> >
> > [1] https://reviews.apache.org
Re: Code Reviews
Posted by Matthias Friedrich <ma...@mafr.de>.
Hi,
we now have a ReviewBoard group for Crunch, with notifications going
to crunch-dev.
Regards,
Matthias
On Saturday, 2012-10-13, Matthias Friedrich wrote:
> Hi,
>
> Apache runs a ReviewBoard instance [1]. I don't have a lot of
> experience with review software, but I think it would help us
> streamline our process. I expect reviewing large patches and
> suggesting changes would work much better on ReviewBoard than
> on JIRA.
>
> I'd suggest that patches should still be attached to a JIRA issue
> (it's necessary for legal reasons anyway), but larger ones can
> additionally be posted to ReviewBoard.
>
> It looks like everybody can create accounts at ReviewBoard but
> INFRA needs to set up a group for Crunch. I'd make a ticket if
> we decide to give it a try.
>
> Regards,
> Matthias
>
> [1] https://reviews.apache.org
Re: Code Reviews
Posted by Brock Noland <br...@cloudera.com>.
How I learned to stop worrying and love ReviewBoard
I hated RB when I first started contributing to Flume but now I am a fan. The only disadvantage I see is that Jira integration is a little wonky and if you don't use it no RB comments are posted to jira.
In flume we require patches be post both locations.
--
Brock Noland
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
On Saturday, October 13, 2012 at 11:53 AM, Gabriel Reid wrote:
> +1. I've never used ReviewBoard, but it definitely sounds useful for bigger patches.
>
> On 13 Oct 2012, at 15:11, Matthias Friedrich <ma...@mafr.de> wrote:
>
> > Hi,
> >
> > Apache runs a ReviewBoard instance [1]. I don't have a lot of
> > experience with review software, but I think it would help us
> > streamline our process. I expect reviewing large patches and
> > suggesting changes would work much better on ReviewBoard than
> > on JIRA.
> >
> > I'd suggest that patches should still be attached to a JIRA issue
> > (it's necessary for legal reasons anyway), but larger ones can
> > additionally be posted to ReviewBoard.
> >
> > It looks like everybody can create accounts at ReviewBoard but
> > INFRA needs to set up a group for Crunch. I'd make a ticket if
> > we decide to give it a try.
> >
> > Regards,
> > Matthias
> >
> > [1] https://reviews.apache.org
Re: Code Reviews
Posted by Gabriel Reid <ga...@gmail.com>.
+1. I've never used ReviewBoard, but it definitely sounds useful for bigger patches.
On 13 Oct 2012, at 15:11, Matthias Friedrich <ma...@mafr.de> wrote:
> Hi,
>
> Apache runs a ReviewBoard instance [1]. I don't have a lot of
> experience with review software, but I think it would help us
> streamline our process. I expect reviewing large patches and
> suggesting changes would work much better on ReviewBoard than
> on JIRA.
>
> I'd suggest that patches should still be attached to a JIRA issue
> (it's necessary for legal reasons anyway), but larger ones can
> additionally be posted to ReviewBoard.
>
> It looks like everybody can create accounts at ReviewBoard but
> INFRA needs to set up a group for Crunch. I'd make a ticket if
> we decide to give it a try.
>
> Regards,
> Matthias
>
> [1] https://reviews.apache.org
Re: Code Reviews
Posted by Matthias Friedrich <ma...@mafr.de>.
Hi everyone,
thanks for your feedback! I've opened a ticket [1] with INFRA
and I'll ping you when we're ready to go.
Regards,
Matthias
[1] https://issues.apache.org/jira/browse/INFRA-5392
On Saturday, 2012-10-13, Matthias Friedrich wrote:
> Hi,
>
> Apache runs a ReviewBoard instance [1]. I don't have a lot of
> experience with review software, but I think it would help us
> streamline our process. I expect reviewing large patches and
> suggesting changes would work much better on ReviewBoard than
> on JIRA.
>
> I'd suggest that patches should still be attached to a JIRA issue
> (it's necessary for legal reasons anyway), but larger ones can
> additionally be posted to ReviewBoard.
>
> It looks like everybody can create accounts at ReviewBoard but
> INFRA needs to set up a group for Crunch. I'd make a ticket if
> we decide to give it a try.
>
> Regards,
> Matthias
>
> [1] https://reviews.apache.org
Re: Code Reviews
Posted by Matthias Friedrich <ma...@mafr.de>.
Hi Rahul,
On Saturday, 2012-10-13, Rahul wrote:
> +1 to the idea of having Reviewboard. I haven't used it, but I have
> seen other projects using it. I think it would be quite useful to
> have it.
> For posting patches, can we integrate both Jira and ReviewBoard so
> that every patch that gets posted in jira go down to ReviewBoard ?
I have no idea, probably not. JIRA and ReviewBoard accounts are
separate so there's no guarrantee that a patch in JIRA is associated
with the correct user in ReviewBoard (IIRC Atlassian has their own
code review product, probably it would integrate better with JIRA).
But as I said, I have very little experience with code review
software, so let's give it a try and see if it works for us at all
before trying to integrate it better :)
Regards,
Matthias
Re: Code Reviews
Posted by Josh Wills <jo...@gmail.com>.
+1
On Sat, Oct 13, 2012 at 9:02 AM, Rahul <rs...@xebia.com> wrote:
> Hi Matthias,
>
> +1 to the idea of having Reviewboard. I haven't used it, but I have seen
> other projects using it. I think it would be quite useful to have it.
> For posting patches, can we integrate both Jira and ReviewBoard so that
> every patch that gets posted in jira go down to ReviewBoard ?
>
> regards,
> Rahul
>
>
> On 13-10-2012 18:41, Matthias Friedrich wrote:
>>
>> Hi,
>>
>> Apache runs a ReviewBoard instance [1]. I don't have a lot of
>> experience with review software, but I think it would help us
>> streamline our process. I expect reviewing large patches and
>> suggesting changes would work much better on ReviewBoard than
>> on JIRA.
>>
>> I'd suggest that patches should still be attached to a JIRA issue
>> (it's necessary for legal reasons anyway), but larger ones can
>> additionally be posted to ReviewBoard.
>>
>> It looks like everybody can create accounts at ReviewBoard but
>> INFRA needs to set up a group for Crunch. I'd make a ticket if
>> we decide to give it a try.
>>
>> Regards,
>> Matthias
>>
>> [1] https://reviews.apache.org
>
>
Re: Code Reviews
Posted by Rahul <rs...@xebia.com>.
Hi Matthias,
+1 to the idea of having Reviewboard. I haven't used it, but I have seen
other projects using it. I think it would be quite useful to have it.
For posting patches, can we integrate both Jira and ReviewBoard so that
every patch that gets posted in jira go down to ReviewBoard ?
regards,
Rahul
On 13-10-2012 18:41, Matthias Friedrich wrote:
> Hi,
>
> Apache runs a ReviewBoard instance [1]. I don't have a lot of
> experience with review software, but I think it would help us
> streamline our process. I expect reviewing large patches and
> suggesting changes would work much better on ReviewBoard than
> on JIRA.
>
> I'd suggest that patches should still be attached to a JIRA issue
> (it's necessary for legal reasons anyway), but larger ones can
> additionally be posted to ReviewBoard.
>
> It looks like everybody can create accounts at ReviewBoard but
> INFRA needs to set up a group for Crunch. I'd make a ticket if
> we decide to give it a try.
>
> Regards,
> Matthias
>
> [1] https://reviews.apache.org