[GitHub] [druid] kfaraz commented on pull request #13850: Docs: Add hadoop based multi-dimension partitioning doc

["kfaraz (via GitHub)" <gi...@apache.org>]

kfaraz commented on PR #13850:
URL: https://github.com/apache/druid/pull/13850#issuecomment-1446516577

   Thanks for the changes, @hqx871 .
   It seems that the added lines have been copied over from the doc on native batch ingestion [here](https://github.com/apache/druid/blob/master/docs/ingestion/native-batch.md#multi-dimension-range-partitioning). It would be better to just add a reference to that content rather than copying the same information.
   
   Since range partitioning is now supported with both hadoop and native batch, it would even make sense to pull out the descriptions of various kinds of secondary partitioning (hash, range and dynamic) into the partitioning doc (`partitioning.md`) itself and just add references to these in `native-ingestion.md` and `hadoop-ingestion.md` docs.
   @techdocsmith , @317brian , what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org