[GitHub] [solr] janhoy commented on a diff in pull request #1807: Update org.apache.zookeeper:* to v3.9.0

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on code in PR #1807:
URL: https://github.com/apache/solr/pull/1807#discussion_r1298247617


##########
versions.lock:
##########
@@ -114,12 +114,14 @@ io.netty:netty-codec-http:4.1.96.Final (3 constraints: 582436ee)
 io.netty:netty-codec-http2:4.1.96.Final (1 constraints: ed0a94cb)
 io.netty:netty-codec-socks:4.1.96.Final (1 constraints: 160fb96c)
 io.netty:netty-common:4.1.96.Final (12 constraints: 3cb3817d)
-io.netty:netty-handler:4.1.96.Final (3 constraints: 732b553d)
+io.netty:netty-handler:4.1.96.Final (3 constraints: 722b4f3d)
 io.netty:netty-handler-proxy:4.1.96.Final (1 constraints: ed0a94cb)
 io.netty:netty-resolver:4.1.96.Final (2 constraints: 5c1a8332)
+io.netty:netty-tcnative-boringssl-static:2.0.61.Final (1 constraints: d10fc38e)
+io.netty:netty-tcnative-classes:2.0.61.Final (1 constraints: d113ea5d)

Review Comment:
   `tcnative-boringssl` is pulled in due to https://issues.apache.org/jira/browse/ZOOKEEPER-4622 which adds more performant SSL support. Do you think we can safely exclude this dependency from Solr? I could not read from the JIRA whether this is opt-in or applies to the zk client, server or both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org