You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "chaokunyang (via GitHub)" <gi...@apache.org> on 2024/04/22 13:22:59 UTC
[PR] feat(java): type meta encoding for java [incubator-fury]
chaokunyang opened a new pull request, #1556:
URL: https://github.com/apache/incubator-fury/pull/1556
## What does this PR do?
This PR implements type meta encoding for java proposed in #1240
## Related issues
#1240
#203
#202
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an issue](https://github.com/apache/incubator-fury/issues/new/choose) describing the need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): type meta encoding for java [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1556:
URL: https://github.com/apache/incubator-fury/pull/1556#issuecomment-2085995796
@theweipeng @LiangliangSui @PragmaTwice Could you help take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): type meta encoding for java [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1556:
URL: https://github.com/apache/incubator-fury/pull/1556#issuecomment-2088623073
Hi @MrChang0, if you are using meta share mode, I believe your case can benefit from this PR too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): type meta encoding for java [incubator-fury]
Posted by "MrChang0 (via GitHub)" <gi...@apache.org>.
MrChang0 commented on PR #1556:
URL: https://github.com/apache/incubator-fury/pull/1556#issuecomment-2089618654
> Hi @MrChang0, if you are using meta share mode, I believe your case can benefit from this PR too.
I perfer think `COMPATIBLE + metaContext` is best way for me, it takes high performance, little data and we can add/delete fields(not like protosuff)
btw, shared metaContext will take some trouble in RPC so I serialize metaContext every time. will this feature merge recently so that I can use it when after holiday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): type meta encoding for java [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1556:
URL: https://github.com/apache/incubator-fury/pull/1556#issuecomment-2090893296
> > Hi @MrChang0, if you are using meta share mode, I believe your case can benefit from this PR too.
>
> I perfer think `COMPATIBLE + metaContext` is best way for me, it takes high performance, little data and we can add/delete fields(not like protosuff) btw, shared metaContext will take some trouble in RPC so I serialize metaContext every time. will this feature merge recently so that I can use it when after holiday.
This will be merged soon and I will submit some prs later to support serialize set and meta context everytime automatically. Automatic meta share mode will be the default compatible mode on the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): type meta encoding for java [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #1556:
URL: https://github.com/apache/incubator-fury/pull/1556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org