You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2009/12/22 10:18:29 UTC
[jira] Created: (FELIX-1959) Move towards unified L&F and extended
branding support
Move towards unified L&F and extended branding support
------------------------------------------------------
Key: FELIX-1959
URL: https://issues.apache.org/jira/browse/FELIX-1959
Project: Felix
Issue Type: New Feature
Components: Web Console
Reporter: Valentin Valchev
Priority: Minor
Attachments: jqueryui-vs-default-lnf.png
Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
- no time to spend on writing widgets already in the library
- clean CSS visual styling
- easy way to change the L&F by changing the theme (extended branding support!)
- improved cross-browser support (JQuery UI takes care of CSS differences)
Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
The attached image contains the combined screen-shots.
"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1959) Move towards unified L&F and extended
branding support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed FELIX-1959.
-----------------------------------
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Felix Meschberger
> Priority: Minor
> Fix For: webconsole-3.0.0
>
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar, tb6_1.0.1.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1959) Move towards unified L&F and
extended branding support
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797363#action_12797363 ]
Felix Meschberger commented on FELIX-1959:
------------------------------------------
Cool. Thanks alot.
>From my point of view, this is definitely worth pursuing !
JQueryUI: We do not have any concrete plans but if you provide a patch to the current web console, which includes JQuery UI, we will definitely include it.
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar, tb6_1.0.1.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1959) Move towards unified L&F and
extended branding support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793956#action_12793956 ]
Carsten Ziegeler commented on FELIX-1959:
-----------------------------------------
Yes, I think we should move forward with this!
Maybe we should start by adding the libraries to the console and then migrate one plugin after the other.
When we have migrated all plugins we could cleanup the html/css of the console itself
And having i18n support would be a real nice thing...but maybe we could do this afterwards?
So if you have any patches, Valentin, they're more than welcome :)
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1959) Move towards unified L&F and
extended branding support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793585#action_12793585 ]
Carsten Ziegeler commented on FELIX-1959:
-----------------------------------------
Looks really cool!
I completly agree that having a common look at and feel across all plugins is desirable.
The current implementation of some plugins when it comes to rendering is too complex. We generate partial html, have javascript that adds missing html etc. Very confusing and error prone.
One idee I discussed briefly with Felix M., was to go one step back and make the plugins deliver all html - without styling, without javascript etc. and then add the dynamic stuff via jquery.
I haven't done anything with jQuery UI (but will do in the next days). If it helps in making the development of plugins easier and more consistent, I'm all for it!
Could you show some sample code of how this would look like from the development perspective?
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1959) Move towards unified L&F and extended
branding support
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-1959:
------------------------------------
Attachment: tb6_1.0.1.jar
Attached tb6_1.0.1.jar
Available plugins:
- log
- license
- config manager
- vmstat (System Information)
New features:
- simplified & unified :&F. The bundles only deploy plain HTML with minimal styling. Static elements (button, input boxes) gets automatically updated with the theme colors. (See support.css & support.js)
- i18n support - simple but efficient
- SimpleWebConsolePlugins with build-in i18n, templates support, template caching.
- examples!
- all plugins with English & Bulgarian language support :)
Issues:
The default Web Console stylesheet included in the header changes the original L&F. It's most visible in vmstat - table gets left and right border, but shouldn't and in log - the links get green.
What I'm going to do next is the bundles manager plugin. I need you opinion - should I continue or not? Do you plan adding JQuery UI to the Web Console, if so - when?
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar, tb6_1.0.1.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1959) Move towards unified L&F and extended
branding support
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-1959:
------------------------------------
Attachment: jqueryui-vs-default-lnf.png
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1959) Move towards unified L&F and
extended branding support
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793658#action_12793658 ]
Felix Meschberger commented on FELIX-1959:
------------------------------------------
This looks very promising -- but also like a big change in various rendering areas.
Can we do this step by step aka "page by page" ?
Anyways, a big +1 for pursuiing this.
... and investigation of internationalization would be a nice thing.
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1959) Move towards unified L&F and extended
branding support
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved FELIX-1959.
--------------------------------------
Resolution: Fixed
Fix Version/s: webconsole-3.0.0
Assignee: Felix Meschberger (was: Carsten Ziegeler)
This can be considered implemented/fixed as of FELIX-1988
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Felix Meschberger
> Priority: Minor
> Fix For: webconsole-3.0.0
>
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar, tb6_1.0.1.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1959) Move towards unified L&F and extended
branding support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned FELIX-1959:
---------------------------------------
Assignee: Carsten Ziegeler
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1959) Move towards unified L&F and extended
branding support
Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Valchev updated FELIX-1959:
------------------------------------
Attachment: tb6.jar
Ok, I've added the LogService refactored to use JQueryUI internally. Of course, the JQueryUI is exported temporally by plug-in resource, since it is not yet exported by the console itself.
You can check the themes in a very simple way:
- set the system property 'webconsole.alternative.theme=true'
- update the bundle
- refresh the web browser (Ctrl+F5)
This is just proof of concept and is just code copied from the original log service with some modifications but it's not optimized to run at it's best performance. There are a number of optimizations that can be performed, if it is supposed to replace the original LogService. As example it can improved by:
- caching of the loaded resource (data.html)
- adding possibility to load the resource using the request locale (load data_en.html, data_fr.html, depending on request.getLocales()).
> Move towards unified L&F and extended branding support
> ------------------------------------------------------
>
> Key: FELIX-1959
> URL: https://issues.apache.org/jira/browse/FELIX-1959
> Project: Felix
> Issue Type: New Feature
> Components: Web Console
> Reporter: Valentin Valchev
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: jqueryui-vs-default-lnf.png, tb6.jar
>
>
> Currently the Web Console uses heavily on the JQuery framework. Using a unified JavaScript framework simplifies development of all plugins and unifies the used approach.
> However, when talking about visual styling, there are number of differences because each plugin developer uses own styles.
> My suggestion is to adopt the JQuery UI . The benefits of using it as unified widget/css framework are:
> - no time to spend on writing widgets already in the library
> - clean CSS visual styling
> - easy way to change the L&F by changing the theme (extended branding support!)
> - improved cross-browser support (JQuery UI takes care of CSS differences)
> Using the JQuery UI framework the developer shouldn't care about color but only for layout - components position; and for data being displayed.
> To illustrate the benefits I've saved the "Log Service" page, modified it to use JQuery UI, took screen-shot, modified the theme CSS only, and again took screen-shot, and finally added the original L&F for reference, so you can easily compare the result.
> The attached image contains the combined screen-shots.
> "
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.