[jira] [Work logged] (KNOX-3021) Http connection properties are not applied when SSL is disabled

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-3021?focusedWorklogId=909862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909862 ]

ASF GitHub Bot logged work on KNOX-3021:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/24 10:51
            Start Date: 14/Mar/24 10:51
    Worklog Time Spent: 10m 
      Work Description: smolnar82 opened a new pull request, #882:
URL: https://github.com/apache/knox/pull/882

   ## What changes were proposed in this pull request?
   
   as described in KNOX-3021, when SSL is disabled, the created Jetty connector are not populated with the pre-configured HTTP configuration. This patch fixes this issue.
   
   ## How was this patch tested?
   
   Added new unit tests and executed the entire test set locally.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 909862)
    Remaining Estimate: 0h
            Time Spent: 10m

> Http connection properties are not applied when SSL is disabled
> ---------------------------------------------------------------
>
>                 Key: KNOX-3021
>                 URL: https://issues.apache.org/jira/browse/KNOX-3021
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 2.0.0, 1.6.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Critical
>             Fix For: 2.1.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is what we have now:
> {noformat}
>       HttpConfiguration httpConfig = new HttpConfiguration();
>       httpConfig.setRequestHeaderSize( config.getHttpServerRequestHeaderBuffer() );
>       httpConfig.setResponseHeaderSize( config.getHttpServerResponseHeaderBuffer() );
>       httpConfig.setOutputBufferSize( config.getHttpServerResponseBuffer() );
>       if (config.isSSLEnabled()) {
>         HttpConfiguration httpsConfig = new HttpConfiguration( httpConfig );
>         ...
>         connector = new ServerConnector( server, sslContextFactory, new HttpConnectionFactory( httpsConfig ) );
>       } else {
>         connector = new ServerConnector( server );
>       } {noformat}
> When SSL is not enabled, the previously created {{httpConfig}} is not set in the created {{ServerConnector}} instance. Therefore, those properties do not take effect in those clusters.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)