[GitHub] fabiograsso commented on issue #1539: Will ngx_pagespeed affect the use of http / 2 server push?

[GitBox <gi...@apache.org>]

fabiograsso commented on issue #1539: Will ngx_pagespeed affect the use of http / 2 server push?
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1539#issuecomment-377493375
 
 
   I've tried using hint_preload_subresources but I've found that the Link header are sent with the "nopush" attribute
   
   This is also what's reported on example in PageSpeed documentation: https://www.modpagespeed.com/doc/filter-hint-preload-subresources
   
   > Then PageSpeed will add the following HTTP headers to the page:
   > 
   > ```
   > link: </styles_all_styles.css>; rel=preload; as=style; nopush
   > link: </basic.css>; rel=preload; as=style; nopush
   > link: </fancy.css>; rel=preload; as=style; nopush
   > link: </script.js>; rel=preload; as=script; nopush
   > ```
   
   According to [nginx documentation](https://www.nginx.com/blog/nginx-1-13-9-http2-server-push/):
   
   > If you don’t want NGINX to push a preloaded resource, add a nopush parameter to the header:
   > 
   > ```
   > # Resource is not pushed
   > Link: </nginx.png>; as=image; rel=preload; nopush
   > ```
   
   I don't know if there is a way for setup PageSpeed in order to not send the "nopush" but if not it's normal for the push to fail, and it's working as expected. I wonder why this choice to put nopush in the headers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services