You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Liochon (JIRA)" <ji...@apache.org> on 2013/12/05 10:08:39 UTC
[jira] [Updated] (HBASE-9867) Save on array copies with a subclass
of LiteralByteString
[ https://issues.apache.org/jira/browse/HBASE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Liochon updated HBASE-9867:
-----------------------------------
Release Note: (was: Committed to trunk and 0.96. Thanks for reviews lads.)
> Save on array copies with a subclass of LiteralByteString
> ---------------------------------------------------------
>
> Key: HBASE-9867
> URL: https://issues.apache.org/jira/browse/HBASE-9867
> Project: HBase
> Issue Type: Improvement
> Components: Protobufs
> Affects Versions: 0.96.0
> Reporter: stack
> Assignee: stack
> Fix For: 0.98.0, 0.96.1
>
> Attachments: 9867.096.txt, 9867.txt, 9867.txt, 9867v2.txt
>
>
> Any time we add a byte array to a protobuf, it'll copy the byte array.
> I was playing with the client and noticed how a bunch of CPU and copying was being done just to copy basic arrays doing pb construction. I started to look at ByteString and then remembered a class Benoit sent me a while back that I did not understand from his new AsyncHBase. After looking in ByteString it made now sense. So, rather than copy byte arrays everywhere, do a version of a ByteString that instead wraps the array.
--
This message was sent by Atlassian JIRA
(v6.1#6144)