[GitHub] [activemq-artemis] gemmellr commented on pull request #3819: ARTEMIS-3541 createQueue ignoring autoDeleteAddress flag

[GitBox <gi...@apache.org>]

gemmellr commented on pull request #3819:
URL: https://github.com/apache/activemq-artemis/pull/3819#issuecomment-952692716


   The change looks reasonable in terms of behaviour for the management issue that was raised, but I wonder about its impact on the non-management cases.
   
   It seems this method is also used during operation of the general queue/address auto-deletion sweeps added in ARTEMIS-3502, passing the current address settings auto-deletion config to the queue deletion operation. I'd guess thats likely partly why the change causing this issue was originally made, to stop the address being immediately deleted along with the queue, but rather handled separately (but typically right afterwards) by the address sweeping process with the same '2 sweeps then delete' behaviour to stop churn. Obviously that doesnt work for the management case when that sweep process is disabled, as was seen.
   
   Perhaps the sweeper or management bits need their own method/arg to govern the behaviour to their needs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org