You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by ji...@apache.org on 2022/11/15 02:30:45 UTC

[shardingsphere] branch master updated: test(issue-21460): SetReadwriteSplittingHintStatement (#22167)

This is an automated email from the ASF dual-hosted git repository.

jianglongtao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 675b2a078b1 test(issue-21460): SetReadwriteSplittingHintStatement (#22167)
675b2a078b1 is described below

commit 675b2a078b12b8459b1c863c92c7ede8f82d6c4e
Author: Xin Huang <57...@users.noreply.github.com>
AuthorDate: Tue Nov 15 10:30:34 2022 +0800

    test(issue-21460): SetReadwriteSplittingHintStatement (#22167)
    
    * test(issue-21460): SetReadwriteSplittingHintStatement
    
    * test(issue-21460): remove debug part
---
 .../distsql/ral/impl/HintRALStatementAssert.java   |  5 +++
 .../SetReadwriteSplittingHintStatementAssert.java  | 52 ++++++++++++++++++++++
 ...SetReadwriteSplittingHintStatementTestCase.java |  9 ++++
 test/parser/src/main/resources/case/ral/hint.xml   |  2 +-
 4 files changed, 67 insertions(+), 1 deletion(-)

diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/HintRALStatementAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/HintRALStatementAssert.java
index 0718767fabe..11c63ef31e3 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/HintRALStatementAssert.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/HintRALStatementAssert.java
@@ -23,14 +23,17 @@ import org.apache.shardingsphere.distsql.parser.statement.ral.HintRALStatement;
 import org.apache.shardingsphere.sharding.distsql.parser.statement.hint.AddShardingHintDatabaseValueStatement;
 import org.apache.shardingsphere.sharding.distsql.parser.statement.hint.AddShardingHintTableValueStatement;
 import org.apache.shardingsphere.sharding.distsql.parser.statement.hint.SetShardingHintDatabaseValueStatement;
+import org.apache.shardingsphere.readwritesplitting.distsql.parser.statement.hint.SetReadwriteSplittingHintStatement;
 import org.apache.shardingsphere.test.sql.parser.internal.asserts.SQLCaseAssertContext;
 import org.apache.shardingsphere.test.sql.parser.internal.asserts.statement.distsql.ral.impl.hint.AddShardingHintDatabaseValueStatementAssert;
 import org.apache.shardingsphere.test.sql.parser.internal.asserts.statement.distsql.ral.impl.hint.AddShardingHintTableValueStatementAssert;
 import org.apache.shardingsphere.test.sql.parser.internal.asserts.statement.distsql.ral.impl.hint.SetShardingHintDatabaseValueStatementAssert;
+import org.apache.shardingsphere.test.sql.parser.internal.asserts.statement.distsql.ral.impl.hint.SetReadwriteSplittingHintStatementAssert;
 import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.SQLParserTestCase;
 import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.distsql.ral.AddShardingHintDatabaseValueStatementTestCase;
 import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.distsql.ral.AddShardingHintTableValueStatementTestCase;
 import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.distsql.ral.SetShardingHintDatabaseValueStatementTestCase;
+import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.distsql.ral.SetReadwriteSplittingHintStatementTestCase;
 
 /**
  * Hint RAL statement assert.
@@ -52,6 +55,8 @@ public class HintRALStatementAssert {
             AddShardingHintDatabaseValueStatementAssert.assertIs(assertContext, (AddShardingHintDatabaseValueStatement) actual, (AddShardingHintDatabaseValueStatementTestCase) expected);
         } else if (actual instanceof SetShardingHintDatabaseValueStatement) {
             SetShardingHintDatabaseValueStatementAssert.assertIs(assertContext, (SetShardingHintDatabaseValueStatement) actual, (SetShardingHintDatabaseValueStatementTestCase) expected);
+        } else if (actual instanceof SetReadwriteSplittingHintStatement) {
+            SetReadwriteSplittingHintStatementAssert.assertIs(assertContext, (SetReadwriteSplittingHintStatement) actual, (SetReadwriteSplittingHintStatementTestCase) expected);
         }
     }
 }
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/hint/SetReadwriteSplittingHintStatementAssert.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/hint/SetReadwriteSplittingHintStatementAssert.java
new file mode 100644
index 00000000000..c9dd0723c37
--- /dev/null
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/asserts/statement/distsql/ral/impl/hint/SetReadwriteSplittingHintStatementAssert.java
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.test.sql.parser.internal.asserts.statement.distsql.ral.impl.hint;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+import org.apache.shardingsphere.readwritesplitting.distsql.parser.statement.hint.SetReadwriteSplittingHintStatement;
+import org.apache.shardingsphere.test.sql.parser.internal.asserts.SQLCaseAssertContext;
+import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.distsql.ral.SetReadwriteSplittingHintStatementTestCase;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+
+/**
+ * Set read write splitting hint statement assert.
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public class SetReadwriteSplittingHintStatementAssert {
+    
+    /**
+     * Assert set read write splitting hint source statement is correct with expected parser result.
+     *
+     * @param assertContext assert context
+     * @param actual actual set read write splitting hint source statement
+     * @param expected expected set read write splitting hint source statement test case
+     */
+    public static void assertIs(final SQLCaseAssertContext assertContext, final SetReadwriteSplittingHintStatement actual, final SetReadwriteSplittingHintStatementTestCase expected) {
+        if (null == expected) {
+            assertNull(assertContext.getText("Actual statement should not exist."), actual);
+        } else {
+            assertNotNull(assertContext.getText("Actual statement should exist."), actual);
+            assertThat(actual.getSource(), is(expected.getSource()));
+        }
+    }
+}
diff --git a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/jaxb/cases/domain/statement/distsql/ral/SetReadwriteSplittingHintStatementTestCase.java b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/jaxb/cases/domain/statement/distsql/ral/SetReadwriteSplittingHintStatementTestCase.java
index 64d46a43c62..a937feb81f2 100644
--- a/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/jaxb/cases/domain/statement/distsql/ral/SetReadwriteSplittingHintStatementTestCase.java
+++ b/test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/internal/jaxb/cases/domain/statement/distsql/ral/SetReadwriteSplittingHintStatementTestCase.java
@@ -17,10 +17,19 @@
 
 package org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.distsql.ral;
 
+import lombok.Getter;
+import lombok.Setter;
 import org.apache.shardingsphere.test.sql.parser.internal.jaxb.cases.domain.statement.SQLParserTestCase;
 
+import javax.xml.bind.annotation.XmlAttribute;
+
 /**
  * Set readwrite-splitting hint statement test case.
  */
+@Getter
+@Setter
 public final class SetReadwriteSplittingHintStatementTestCase extends SQLParserTestCase {
+    
+    @XmlAttribute(name = "source-name")
+    private String source;
 }
diff --git a/test/parser/src/main/resources/case/ral/hint.xml b/test/parser/src/main/resources/case/ral/hint.xml
index c7f406c713a..7304dee214d 100644
--- a/test/parser/src/main/resources/case/ral/hint.xml
+++ b/test/parser/src/main/resources/case/ral/hint.xml
@@ -24,7 +24,7 @@
     <clear-sharding-hint sql-case-id="clear-sharding-hint" />
     
     <show-readwrite-splitting-hint-source sql-case-id="show-readwrite-splitting-hint-source" />
-    <set-readwrite-splitting-hint-source sql-case-id="set-readwrite-splitting-hint-source" />
+    <set-readwrite-splitting-hint-source sql-case-id="set-readwrite-splitting-hint-source" source-name="WRITE"/>
     <clear-readwrite-splitting-hint-source sql-case-id="clear-readwrite-splitting-hint-source" />
     
     <clear-hint sql-case-id="clear-hint" />